Commit df1bdc06 authored by Nick Piggin's avatar Nick Piggin Committed by Linus Torvalds

x86: fence oostores on 64-bit

movnt* instructions are not strongly ordered with respect to other stores,
so if we are to assume stores are strongly ordered in the rest of the 64
bit code, we must fence these off (see similar examples in 32 bit code).

[ The AMD memory ordering document seems to say that nontemporal stores can
  also pass earlier regular stores, so maybe we need sfences _before_
  movnt* everywhere too? ]
Signed-off-by: default avatarNick Piggin <npiggin@suse.de>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 2b9e0aae
...@@ -117,6 +117,7 @@ ENTRY(__copy_user_nocache) ...@@ -117,6 +117,7 @@ ENTRY(__copy_user_nocache)
popq %rbx popq %rbx
CFI_ADJUST_CFA_OFFSET -8 CFI_ADJUST_CFA_OFFSET -8
CFI_RESTORE rbx CFI_RESTORE rbx
sfence
ret ret
CFI_RESTORE_STATE CFI_RESTORE_STATE
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment