Commit db812467 authored by Andrew Morton's avatar Andrew Morton Committed by james toy

ERROR: code indent should use tabs where possible

#90: FILE: lib/zlib_inflate/inffast.c:250:
+                    /* minimum length is three */$

ERROR: space prohibited before that close parenthesis ')'
#97: FILE: lib/zlib_inflate/inffast.c:257:
+		    if (dist > 2 ) {

WARNING: suspect code indent for conditional statements (24, 28)
#111: FILE: lib/zlib_inflate/inffast.c:271:
+			if (dist == 1)
[...]
+			    pat16 = (pat16 & 0xff) | ((pat16 & 0xff ) << 8);

ERROR: space prohibited before that close parenthesis ')'
#113: FILE: lib/zlib_inflate/inffast.c:273:
+			    pat16 = (pat16 & 0xff) | ((pat16 & 0xff ) << 8);

ERROR: space prohibited before that close parenthesis ')'
#115: FILE: lib/zlib_inflate/inffast.c:275:
+			    pat16 = (pat16 & 0xff00) | ((pat16 & 0xff00 ) >> 8);

total: 4 errors, 1 warnings, 93 lines checked

./patches/zlib-optimize-inffast-when-copying-direct-from-output.patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 9dad9789
...@@ -247,14 +247,14 @@ void inflate_fast(z_streamp strm, unsigned start) ...@@ -247,14 +247,14 @@ void inflate_fast(z_streamp strm, unsigned start)
unsigned long loops; unsigned long loops;
from = out - dist; /* copy direct from output */ from = out - dist; /* copy direct from output */
/* minimum length is three */ /* minimum length is three */
/* Align out addr */ /* Align out addr */
if (!((long)(out - 1 + OFF) & 1)) { if (!((long)(out - 1 + OFF) & 1)) {
PUP(out) = PUP(from); PUP(out) = PUP(from);
len--; len--;
} }
sout = (unsigned short *)(out - OFF); sout = (unsigned short *)(out - OFF);
if (dist > 2 ) { if (dist > 2) {
unsigned short *sfrom; unsigned short *sfrom;
sfrom = (unsigned short *)(from - OFF); sfrom = (unsigned short *)(from - OFF);
...@@ -270,9 +270,9 @@ void inflate_fast(z_streamp strm, unsigned start) ...@@ -270,9 +270,9 @@ void inflate_fast(z_streamp strm, unsigned start)
pat16 = *(sout-2+2*OFF); pat16 = *(sout-2+2*OFF);
if (dist == 1) if (dist == 1)
#if defined(__BIG_ENDIAN) #if defined(__BIG_ENDIAN)
pat16 = (pat16 & 0xff) | ((pat16 & 0xff ) << 8); pat16 = (pat16 & 0xff) | ((pat16 & 0xff) << 8);
#elif defined(__LITTLE_ENDIAN) #elif defined(__LITTLE_ENDIAN)
pat16 = (pat16 & 0xff00) | ((pat16 & 0xff00 ) >> 8); pat16 = (pat16 & 0xff00) | ((pat16 & 0xff00) >> 8);
#else #else
#error __BIG_ENDIAN nor __LITTLE_ENDIAN is defined #error __BIG_ENDIAN nor __LITTLE_ENDIAN is defined
#endif #endif
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment