Commit d76f2f44 authored by Alan Cox's avatar Alan Cox Committed by Linus Torvalds

io_edgeport: Fix various bogus returns to the tty layer

The edgeport reports negative error codes to functions that do not
expect them. This can cause ports to jam forever
Signed-off-by: default avatarAlan Cox <alan@redhat.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 03f0dbf7
......@@ -1404,15 +1404,15 @@ static int edge_write_room(struct tty_struct *tty)
dbg("%s", __func__);
if (edge_port == NULL)
return -ENODEV;
return 0;
if (edge_port->closePending)
return -ENODEV;
return 0;
dbg("%s - port %d", __func__, port->number);
if (!edge_port->open) {
dbg("%s - port not opened", __func__);
return -EINVAL;
return 0;
}
/* total of both buffers is still txCredit */
......@@ -1444,13 +1444,13 @@ static int edge_chars_in_buffer(struct tty_struct *tty)
dbg("%s", __func__);
if (edge_port == NULL)
return -ENODEV;
return 0;
if (edge_port->closePending)
return -ENODEV;
return 0;
if (!edge_port->open) {
dbg("%s - port not opened", __func__);
return -EINVAL;
return 0;
}
spin_lock_irqsave(&edge_port->ep_lock, flags);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment