Commit d2fbd0f2 authored by Alan Cox's avatar Alan Cox Committed by Linus Torvalds

specialix: Code cleanups

Go through the inlines and other oddments that are iffy. Remove various bits
of dead code and bogus debug. Turn the crtsdts compile time option into a
runtime switch.
Signed-off-by: default avatarAlan Cox <alan@redhat.com>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent a72492bd
...@@ -270,8 +270,8 @@ The pinout of the connectors on the IO8+ is: ...@@ -270,8 +270,8 @@ The pinout of the connectors on the IO8+ is:
Hardware handshaking issues. Hardware handshaking issues.
============================ ============================
The driver can be compiled in two different ways. The default The driver can be told to operate in two different ways. The default
("Specialix DTR/RTS pin is RTS" is off) the pin behaves as DTR when behaviour is specialix.sx_rtscts = 0 where the pin behaves as DTR when
hardware handshaking is off. It behaves as the RTS hardware hardware handshaking is off. It behaves as the RTS hardware
handshaking signal when hardware handshaking is selected. handshaking signal when hardware handshaking is selected.
...@@ -280,7 +280,7 @@ cable will either be compatible with hardware handshaking or with ...@@ -280,7 +280,7 @@ cable will either be compatible with hardware handshaking or with
software handshaking. So switching on the fly is not really an software handshaking. So switching on the fly is not really an
option. option.
I actually prefer to use the "Specialix DTR/RTS pin is RTS" option. I actually prefer to use the "specialix.sx_rtscts=1" option.
This makes the DTR/RTS pin always an RTS pin, and ioctls to This makes the DTR/RTS pin always an RTS pin, and ioctls to
change DTR are always ignored. I have a cable that is configured change DTR are always ignored. I have a cable that is configured
for this. for this.
...@@ -379,7 +379,5 @@ it doesn't fit in your computer, bring back the card. ...@@ -379,7 +379,5 @@ it doesn't fit in your computer, bring back the card.
You have to WRITE to the address register to even You have to WRITE to the address register to even
read-probe a CD186x register. Disable autodetection? read-probe a CD186x register. Disable autodetection?
-- Specialix: any suggestions? -- Specialix: any suggestions?
- Arbitrary baud rates are not implemented yet.
If you need this, bug me about it.
...@@ -300,16 +300,6 @@ config SPECIALIX ...@@ -300,16 +300,6 @@ config SPECIALIX
and compile this driver as kernel loadable module which will be and compile this driver as kernel loadable module which will be
called specialix. called specialix.
config SPECIALIX_RTSCTS
bool "Specialix DTR/RTS pin is RTS"
depends on SPECIALIX
help
The Specialix IO8+ card can only support either RTS or DTR. If you
say N here, the driver will use the pin as "DTR" when the tty is in
software handshake mode. If you say Y here or hardware handshake is
on, it will always be RTS. Read the file
<file:Documentation/specialix.txt> for more information.
config SX config SX
tristate "Specialix SX (and SI) card support" tristate "Specialix SX (and SI) card support"
depends on SERIAL_NONSTANDARD && (PCI || EISA || ISA) depends on SERIAL_NONSTANDARD && (PCI || EISA || ISA)
......
This diff is collapsed.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment