Commit c6c35237 authored by Harro Haan's avatar Harro Haan Committed by Russell King

ARM: 5965/1: Fix soft lockup in at91 udc driver

Fix a potential soft lockup in the AT91 UDC driver by ensuring that
the UDC clock is enabled inside the interrupt handler. If the UDC clock is not enabled then the UDC registers cannot be written to
and the interrupt cannot be cleared or masked.

Note that this patch (and other parts of the existing AT91 UDC
driver) is potentially racy for preempt-rt kernels,
but is okay for mainline.

For more info see:

http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100203/09cdb3b4/attachment.el

http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100203/8443a1e4/attachment.elSigned-off-by: default avatarRyan Mallon <ryan@bluewatersys.com>
Acked-by: default avatarHarro Haan <hrhaan@gmail.com>
Tested-by: default avatarRemy Bohmer <linux@bohmer.net>
Acked-by: default avatarAndrew Victor <avictor.za@gmail.com>
Cc: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
parent fd522a8d
...@@ -1370,6 +1370,12 @@ static irqreturn_t at91_udc_irq (int irq, void *_udc) ...@@ -1370,6 +1370,12 @@ static irqreturn_t at91_udc_irq (int irq, void *_udc)
{ {
struct at91_udc *udc = _udc; struct at91_udc *udc = _udc;
u32 rescans = 5; u32 rescans = 5;
int disable_clock = 0;
if (!udc->clocked) {
clk_on(udc);
disable_clock = 1;
}
while (rescans--) { while (rescans--) {
u32 status; u32 status;
...@@ -1458,6 +1464,9 @@ static irqreturn_t at91_udc_irq (int irq, void *_udc) ...@@ -1458,6 +1464,9 @@ static irqreturn_t at91_udc_irq (int irq, void *_udc)
} }
} }
if (disable_clock)
clk_off(udc);
return IRQ_HANDLED; return IRQ_HANDLED;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment