Commit bc663000 authored by Suman Anna's avatar Suman Anna Committed by Hari Kanigeri

SYSLINK: ipc - removed gt_traces from messageq modules

This patch cleaned up all the gt_traces in messageq modules. Duplicate
BUG_ONs have also been removed. WARN_ONs have been added instead in some
places. Return statements have been added in couple of functions for
successful execution scenarions.
Signed-off-by: default avatarSuman Anna <s-anna@ti.com>
parent 0edf734a
...@@ -24,8 +24,6 @@ ...@@ -24,8 +24,6 @@
#include <linux/bug.h> #include <linux/bug.h>
#include <linux/fs.h> #include <linux/fs.h>
#include <linux/mm.h> #include <linux/mm.h>
/* Syslink headers */
#include <gt.h>
/* Module Headers */ /* Module Headers */
#include <messageq.h> #include <messageq.h>
...@@ -387,10 +385,6 @@ int messageq_ioctl(struct inode *inode, struct file *filp, ...@@ -387,10 +385,6 @@ int messageq_ioctl(struct inode *inode, struct file *filp,
struct messageq_cmd_args cargs; struct messageq_cmd_args cargs;
unsigned long size; unsigned long size;
gt_4trace(curTrace, GT_ENTER, "messageq_ioctl"
"inode: %x, filp: %x,\n cmd: %x, args: %x",
inode, filp, cmd, args);
if (_IOC_DIR(cmd) & _IOC_READ) if (_IOC_DIR(cmd) & _IOC_READ)
os_status = !access_ok(VERIFY_WRITE, uarg, _IOC_SIZE(cmd)); os_status = !access_ok(VERIFY_WRITE, uarg, _IOC_SIZE(cmd));
else if (_IOC_DIR(cmd) & _IOC_WRITE) else if (_IOC_DIR(cmd) & _IOC_WRITE)
...@@ -482,8 +476,9 @@ int messageq_ioctl(struct inode *inode, struct file *filp, ...@@ -482,8 +476,9 @@ int messageq_ioctl(struct inode *inode, struct file *filp,
os_status = -EFAULT; os_status = -EFAULT;
goto exit; goto exit;
} }
return os_status;
exit: exit:
gt_1trace(curTrace, GT_LEAVE, "messageq_ioctl", os_status); printk(KERN_ERR "messageq_ioctl failed: status = 0x%x\n", os_status);
return os_status; return os_status;
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment