Commit baed6b82 authored by Stefan Richter's avatar Stefan Richter

firewire: sbp2: fix freeing of unallocated memory

If a target writes invalid status (typically status of a command that
already timed out), firewire-sbp2 attempts to put away an ORB that
doesn't exist.  https://bugzilla.redhat.com/show_bug.cgi?id=519772Signed-off-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>
parent 4fe0badd
...@@ -456,12 +456,12 @@ static void sbp2_status_write(struct fw_card *card, struct fw_request *request, ...@@ -456,12 +456,12 @@ static void sbp2_status_write(struct fw_card *card, struct fw_request *request,
} }
spin_unlock_irqrestore(&card->lock, flags); spin_unlock_irqrestore(&card->lock, flags);
if (&orb->link != &lu->orb_list) if (&orb->link != &lu->orb_list) {
orb->callback(orb, &status); orb->callback(orb, &status);
else kref_put(&orb->kref, free_orb);
} else {
fw_error("status write for unknown orb\n"); fw_error("status write for unknown orb\n");
}
kref_put(&orb->kref, free_orb);
fw_send_response(card, request, RCODE_COMPLETE); fw_send_response(card, request, RCODE_COMPLETE);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment