Commit b7fcb5c4 authored by Bob Copeland's avatar Bob Copeland Committed by John W. Linville

ath5k: fix buffer overrun in rate debug code

char bname[5] is too small for the string "X GHz" when the null
terminator is taken into account.  Thus, turning on rate debugging
can crash unless we have lucky stack alignment.

Cc: stable@kernel.org
Reported-by: default avatarParide Legovini <legovini@spiro.fisica.unipd.it>
Signed-off-by: default avatarBob Copeland <me@bobcopeland.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 74aa9be0
...@@ -424,7 +424,7 @@ ath5k_debug_dump_bands(struct ath5k_softc *sc) ...@@ -424,7 +424,7 @@ ath5k_debug_dump_bands(struct ath5k_softc *sc)
for (b = 0; b < IEEE80211_NUM_BANDS; b++) { for (b = 0; b < IEEE80211_NUM_BANDS; b++) {
struct ieee80211_supported_band *band = &sc->sbands[b]; struct ieee80211_supported_band *band = &sc->sbands[b];
char bname[5]; char bname[6];
switch (band->band) { switch (band->band) {
case IEEE80211_BAND_2GHZ: case IEEE80211_BAND_2GHZ:
strcpy(bname, "2 GHz"); strcpy(bname, "2 GHz");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment