Commit b6070f07 authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab

V4L/DVB (9931): em28xx: de-obfuscate vidioc_g_ctrl logic

vidioc_g_ctrl() were using an uneeded confusing logic. Instead, use the
direct approach.
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 5db0b5e1
...@@ -1057,18 +1057,14 @@ static int vidioc_g_ctrl(struct file *file, void *priv, ...@@ -1057,18 +1057,14 @@ static int vidioc_g_ctrl(struct file *file, void *priv,
rc = check_dev(dev); rc = check_dev(dev);
if (rc < 0) if (rc < 0)
return rc; return rc;
rc = 0;
mutex_lock(&dev->lock); mutex_lock(&dev->lock);
if (!dev->board.has_msp34xx) if (dev->board.has_msp34xx)
rc = em28xx_get_ctrl(dev, ctrl);
else
rc = -EINVAL;
if (rc == -EINVAL) {
em28xx_i2c_call_clients(dev, VIDIOC_G_CTRL, ctrl); em28xx_i2c_call_clients(dev, VIDIOC_G_CTRL, ctrl);
rc = 0; else
} rc = em28xx_get_ctrl(dev, ctrl);
mutex_unlock(&dev->lock); mutex_unlock(&dev->lock);
return rc; return rc;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment