Commit a8947fcf authored by Sonic Zhang's avatar Sonic Zhang Committed by Greg Kroah-Hartman

staging: iio: Function iio_get_new_idr_val() return negative value if fails.

Function iio_get_new_idr_val() return negative value if fails.
So, only error when ret < 0 in iio_device_register_eventset().
Signed-off-by: default avatarSonic Zhang <sonic.adi@gmail.com>
Acked-by: default avatarJonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent ee58cb2b
...@@ -537,6 +537,7 @@ static void iio_device_unregister_sysfs(struct iio_dev *dev_info) ...@@ -537,6 +537,7 @@ static void iio_device_unregister_sysfs(struct iio_dev *dev_info)
sysfs_remove_group(&dev_info->dev.kobj, dev_info->attrs); sysfs_remove_group(&dev_info->dev.kobj, dev_info->attrs);
} }
/* This function return negative value if fails. */
int iio_get_new_idr_val(struct idr *this_idr) int iio_get_new_idr_val(struct idr *this_idr)
{ {
int ret; int ret;
...@@ -660,7 +661,7 @@ static int iio_device_register_eventset(struct iio_dev *dev_info) ...@@ -660,7 +661,7 @@ static int iio_device_register_eventset(struct iio_dev *dev_info)
for (i = 0; i < dev_info->num_interrupt_lines; i++) { for (i = 0; i < dev_info->num_interrupt_lines; i++) {
dev_info->event_interfaces[i].owner = dev_info->driver_module; dev_info->event_interfaces[i].owner = dev_info->driver_module;
ret = iio_get_new_idr_val(&iio_event_idr); ret = iio_get_new_idr_val(&iio_event_idr);
if (ret) if (ret < 0)
goto error_free_setup_ev_ints; goto error_free_setup_ev_ints;
else else
dev_info->event_interfaces[i].id = ret; dev_info->event_interfaces[i].id = ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment