Commit a6a9a1a3 authored by David Brownell's avatar David Brownell Committed by Tony Lindgren

musb_hdrc, CamelCase begone (cppi struct, locals ...)

Even more CamelCase removal from CPPI:
 - members of cppi_channel struct
 - parameters to cppi_channel_program()
 - "buffSz" local variables
 - "chNum" local variables
 - "regVal" local variables

Also
 - remove the FIXME about using container_of(), that's resolved now
 - stop using the now-pointless private_data fields
 - remove the redundant actualLen field (use dma_channel.actual_len)
 - remove some redundent local variables
Signed-off-by: default avatarDavid Brownell <dbrownell@users.sourceforge.net>
parent 2c63a07e
This diff is collapsed.
...@@ -78,10 +78,7 @@ struct cppi; ...@@ -78,10 +78,7 @@ struct cppi;
/* CPPI Channel Control structure */ /* CPPI Channel Control structure */
struct cppi_channel { struct cppi_channel {
/* First field must be dma_channel for easy type casting struct dma_channel channel;
* FIXME just use container_of() and be typesafe instead!
*/
struct dma_channel Channel;
/* back pointer to the DMA controller structure */ /* back pointer to the DMA controller structure */
struct cppi *controller; struct cppi *controller;
...@@ -89,25 +86,25 @@ struct cppi_channel { ...@@ -89,25 +86,25 @@ struct cppi_channel {
/* which direction of which endpoint? */ /* which direction of which endpoint? */
struct musb_hw_ep *hw_ep; struct musb_hw_ep *hw_ep;
bool transmit; bool transmit;
u8 chNo; u8 index;
/* DMA modes: RNDIS or "transparent" */ /* DMA modes: RNDIS or "transparent" */
u8 bLastModeRndis; u8 is_rndis;
/* book keeping for current transfer request */ /* book keeping for current transfer request */
dma_addr_t startAddr; dma_addr_t buf_dma;
u32 transferSize; u32 buf_len;
u32 pktSize; u32 maxpacket;
u32 currOffset; /* requested segments */ u32 offset; /* dma requested */
u32 actualLen; /* completed (Channel.actual) */
void __iomem *state_ram; /* CPPI state */ void __iomem *state_ram; /* CPPI state */
struct cppi_descriptor *freelist;
/* BD management fields */ /* BD management fields */
struct cppi_descriptor *bdPoolHead; struct cppi_descriptor *head;
struct cppi_descriptor *activeQueueHead; struct cppi_descriptor *tail;
struct cppi_descriptor *activeQueueTail; struct cppi_descriptor *last_processed;
struct cppi_descriptor *lastHwBDProcessed;
/* use tx_complete in host role to track endpoints waiting for /* use tx_complete in host role to track endpoints waiting for
* FIFONOTEMPTY to clear. * FIFONOTEMPTY to clear.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment