Commit a43cdf08 authored by Linus Torvalds's avatar Linus Torvalds

Merge git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc

* git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc:
  [POWERPC] cell: fix bugs found by sparse
  [POWERPC] spiderpic: enable new style devtree support
  [POWERPC] Update cell_defconfig
  [POWERPC] spufs: add infrastructure for finding elf objects
  [POWERPC] spufs: support new OF device tree format
  [POWERPC] spufs: add support for read/write on cntl
  [POWERPC] spufs: remove support for ancient firmware
  [POWERPC] spufs: make mailbox functions handle multiple elements
  [POWERPC] spufs: use correct pg_prot for mapping SPU local store
  [POWERPC] spufs: Add infrastructure needed for gang scheduling
  [POWERPC] spufs: implement error event delivery to user space
  [POWERPC] spufs: fix context switch during page fault
  [POWERPC] spufs: scheduler support for NUMA.
  [POWERPC] spufs: cell spu problem state mapping updates
parents 97d41e90 43b4f406
# #
# Automatically generated make config: don't edit # Automatically generated make config: don't edit
# Linux kernel version: 2.6.18-rc6 # Linux kernel version: 2.6.18
# Sun Sep 10 10:20:32 2006 # Wed Oct 4 15:30:50 2006
# #
CONFIG_PPC64=y CONFIG_PPC64=y
CONFIG_64BIT=y CONFIG_64BIT=y
...@@ -22,6 +22,7 @@ CONFIG_ARCH_MAY_HAVE_PC_FDC=y ...@@ -22,6 +22,7 @@ CONFIG_ARCH_MAY_HAVE_PC_FDC=y
CONFIG_PPC_OF=y CONFIG_PPC_OF=y
CONFIG_PPC_UDBG_16550=y CONFIG_PPC_UDBG_16550=y
# CONFIG_GENERIC_TBSYNC is not set # CONFIG_GENERIC_TBSYNC is not set
CONFIG_AUDIT_ARCH=y
# CONFIG_DEFAULT_UIMAGE is not set # CONFIG_DEFAULT_UIMAGE is not set
# #
...@@ -52,10 +53,11 @@ CONFIG_LOCALVERSION="" ...@@ -52,10 +53,11 @@ CONFIG_LOCALVERSION=""
CONFIG_LOCALVERSION_AUTO=y CONFIG_LOCALVERSION_AUTO=y
CONFIG_SWAP=y CONFIG_SWAP=y
CONFIG_SYSVIPC=y CONFIG_SYSVIPC=y
# CONFIG_IPC_NS is not set
# CONFIG_POSIX_MQUEUE is not set # CONFIG_POSIX_MQUEUE is not set
# CONFIG_BSD_PROCESS_ACCT is not set # CONFIG_BSD_PROCESS_ACCT is not set
# CONFIG_TASKSTATS is not set # CONFIG_TASKSTATS is not set
CONFIG_SYSCTL=y # CONFIG_UTS_NS is not set
# CONFIG_AUDIT is not set # CONFIG_AUDIT is not set
CONFIG_IKCONFIG=y CONFIG_IKCONFIG=y
CONFIG_IKCONFIG_PROC=y CONFIG_IKCONFIG_PROC=y
...@@ -63,7 +65,9 @@ CONFIG_CPUSETS=y ...@@ -63,7 +65,9 @@ CONFIG_CPUSETS=y
# CONFIG_RELAY is not set # CONFIG_RELAY is not set
CONFIG_INITRAMFS_SOURCE="" CONFIG_INITRAMFS_SOURCE=""
CONFIG_CC_OPTIMIZE_FOR_SIZE=y CONFIG_CC_OPTIMIZE_FOR_SIZE=y
CONFIG_SYSCTL=y
# CONFIG_EMBEDDED is not set # CONFIG_EMBEDDED is not set
# CONFIG_SYSCTL_SYSCALL is not set
CONFIG_KALLSYMS=y CONFIG_KALLSYMS=y
# CONFIG_KALLSYMS_ALL is not set # CONFIG_KALLSYMS_ALL is not set
# CONFIG_KALLSYMS_EXTRA_PASS is not set # CONFIG_KALLSYMS_EXTRA_PASS is not set
...@@ -72,12 +76,12 @@ CONFIG_PRINTK=y ...@@ -72,12 +76,12 @@ CONFIG_PRINTK=y
CONFIG_BUG=y CONFIG_BUG=y
CONFIG_ELF_CORE=y CONFIG_ELF_CORE=y
CONFIG_BASE_FULL=y CONFIG_BASE_FULL=y
CONFIG_RT_MUTEXES=y
CONFIG_FUTEX=y CONFIG_FUTEX=y
CONFIG_EPOLL=y CONFIG_EPOLL=y
CONFIG_SHMEM=y CONFIG_SHMEM=y
CONFIG_SLAB=y CONFIG_SLAB=y
CONFIG_VM_EVENT_COUNTERS=y CONFIG_VM_EVENT_COUNTERS=y
CONFIG_RT_MUTEXES=y
# CONFIG_TINY_SHMEM is not set # CONFIG_TINY_SHMEM is not set
CONFIG_BASE_SMALL=0 CONFIG_BASE_SMALL=0
# CONFIG_SLOB is not set # CONFIG_SLOB is not set
...@@ -96,6 +100,7 @@ CONFIG_STOP_MACHINE=y ...@@ -96,6 +100,7 @@ CONFIG_STOP_MACHINE=y
# #
# Block layer # Block layer
# #
CONFIG_BLOCK=y
# CONFIG_BLK_DEV_IO_TRACE is not set # CONFIG_BLK_DEV_IO_TRACE is not set
# #
...@@ -115,12 +120,13 @@ CONFIG_DEFAULT_IOSCHED="anticipatory" ...@@ -115,12 +120,13 @@ CONFIG_DEFAULT_IOSCHED="anticipatory"
# Platform support # Platform support
# #
CONFIG_PPC_MULTIPLATFORM=y CONFIG_PPC_MULTIPLATFORM=y
# CONFIG_PPC_ISERIES is not set
# CONFIG_EMBEDDED6xx is not set # CONFIG_EMBEDDED6xx is not set
# CONFIG_APUS is not set # CONFIG_APUS is not set
# CONFIG_PPC_PSERIES is not set # CONFIG_PPC_PSERIES is not set
# CONFIG_PPC_ISERIES is not set
# CONFIG_PPC_PMAC is not set # CONFIG_PPC_PMAC is not set
# CONFIG_PPC_MAPLE is not set # CONFIG_PPC_MAPLE is not set
# CONFIG_PPC_PASEMI is not set
CONFIG_PPC_CELL=y CONFIG_PPC_CELL=y
CONFIG_PPC_CELL_NATIVE=y CONFIG_PPC_CELL_NATIVE=y
CONFIG_PPC_IBM_CELL_BLADE=y CONFIG_PPC_IBM_CELL_BLADE=y
...@@ -142,7 +148,6 @@ CONFIG_MMIO_NVRAM=y ...@@ -142,7 +148,6 @@ CONFIG_MMIO_NVRAM=y
# #
CONFIG_SPU_FS=m CONFIG_SPU_FS=m
CONFIG_SPU_BASE=y CONFIG_SPU_BASE=y
CONFIG_SPUFS_MMAP=y
CONFIG_CBE_RAS=y CONFIG_CBE_RAS=y
# #
...@@ -158,7 +163,7 @@ CONFIG_PREEMPT_NONE=y ...@@ -158,7 +163,7 @@ CONFIG_PREEMPT_NONE=y
CONFIG_PREEMPT_BKL=y CONFIG_PREEMPT_BKL=y
CONFIG_BINFMT_ELF=y CONFIG_BINFMT_ELF=y
CONFIG_BINFMT_MISC=m CONFIG_BINFMT_MISC=m
CONFIG_FORCE_MAX_ZONEORDER=13 CONFIG_FORCE_MAX_ZONEORDER=9
# CONFIG_IOMMU_VMERGE is not set # CONFIG_IOMMU_VMERGE is not set
CONFIG_ARCH_ENABLE_MEMORY_HOTPLUG=y CONFIG_ARCH_ENABLE_MEMORY_HOTPLUG=y
CONFIG_KEXEC=y CONFIG_KEXEC=y
...@@ -168,6 +173,7 @@ CONFIG_NUMA=y ...@@ -168,6 +173,7 @@ CONFIG_NUMA=y
CONFIG_NODES_SHIFT=4 CONFIG_NODES_SHIFT=4
CONFIG_ARCH_SELECT_MEMORY_MODEL=y CONFIG_ARCH_SELECT_MEMORY_MODEL=y
CONFIG_ARCH_SPARSEMEM_ENABLE=y CONFIG_ARCH_SPARSEMEM_ENABLE=y
CONFIG_ARCH_POPULATES_NODE_MAP=y
CONFIG_SELECT_MEMORY_MODEL=y CONFIG_SELECT_MEMORY_MODEL=y
# CONFIG_FLATMEM_MANUAL is not set # CONFIG_FLATMEM_MANUAL is not set
# CONFIG_DISCONTIGMEM_MANUAL is not set # CONFIG_DISCONTIGMEM_MANUAL is not set
...@@ -178,12 +184,12 @@ CONFIG_HAVE_MEMORY_PRESENT=y ...@@ -178,12 +184,12 @@ CONFIG_HAVE_MEMORY_PRESENT=y
# CONFIG_SPARSEMEM_STATIC is not set # CONFIG_SPARSEMEM_STATIC is not set
CONFIG_SPARSEMEM_EXTREME=y CONFIG_SPARSEMEM_EXTREME=y
CONFIG_MEMORY_HOTPLUG=y CONFIG_MEMORY_HOTPLUG=y
CONFIG_MEMORY_HOTPLUG_SPARSE=y
CONFIG_SPLIT_PTLOCK_CPUS=4 CONFIG_SPLIT_PTLOCK_CPUS=4
CONFIG_MIGRATION=y CONFIG_MIGRATION=y
CONFIG_RESOURCES_64BIT=y CONFIG_RESOURCES_64BIT=y
CONFIG_HAVE_ARCH_EARLY_PFN_TO_NID=y
CONFIG_ARCH_MEMORY_PROBE=y CONFIG_ARCH_MEMORY_PROBE=y
# CONFIG_PPC_64K_PAGES is not set CONFIG_PPC_64K_PAGES=y
CONFIG_SCHED_SMT=y CONFIG_SCHED_SMT=y
CONFIG_PROC_DEVICETREE=y CONFIG_PROC_DEVICETREE=y
# CONFIG_CMDLINE_BOOL is not set # CONFIG_CMDLINE_BOOL is not set
...@@ -201,6 +207,7 @@ CONFIG_GENERIC_ISA_DMA=y ...@@ -201,6 +207,7 @@ CONFIG_GENERIC_ISA_DMA=y
CONFIG_PCI=y CONFIG_PCI=y
CONFIG_PCI_DOMAINS=y CONFIG_PCI_DOMAINS=y
CONFIG_PCIEPORTBUS=y CONFIG_PCIEPORTBUS=y
# CONFIG_PCI_MULTITHREAD_PROBE is not set
# CONFIG_PCI_DEBUG is not set # CONFIG_PCI_DEBUG is not set
# #
...@@ -228,6 +235,7 @@ CONFIG_PACKET=y ...@@ -228,6 +235,7 @@ CONFIG_PACKET=y
CONFIG_UNIX=y CONFIG_UNIX=y
CONFIG_XFRM=y CONFIG_XFRM=y
# CONFIG_XFRM_USER is not set # CONFIG_XFRM_USER is not set
# CONFIG_XFRM_SUB_POLICY is not set
# CONFIG_NET_KEY is not set # CONFIG_NET_KEY is not set
CONFIG_INET=y CONFIG_INET=y
CONFIG_IP_MULTICAST=y CONFIG_IP_MULTICAST=y
...@@ -249,7 +257,8 @@ CONFIG_INET_XFRM_MODE_TUNNEL=y ...@@ -249,7 +257,8 @@ CONFIG_INET_XFRM_MODE_TUNNEL=y
CONFIG_INET_DIAG=y CONFIG_INET_DIAG=y
CONFIG_INET_TCP_DIAG=y CONFIG_INET_TCP_DIAG=y
# CONFIG_TCP_CONG_ADVANCED is not set # CONFIG_TCP_CONG_ADVANCED is not set
CONFIG_TCP_CONG_BIC=y CONFIG_TCP_CONG_CUBIC=y
CONFIG_DEFAULT_TCP_CONG="cubic"
# #
# IP: Virtual Server Configuration # IP: Virtual Server Configuration
...@@ -261,11 +270,15 @@ CONFIG_IPV6=y ...@@ -261,11 +270,15 @@ CONFIG_IPV6=y
CONFIG_INET6_AH=m CONFIG_INET6_AH=m
CONFIG_INET6_ESP=m CONFIG_INET6_ESP=m
CONFIG_INET6_IPCOMP=m CONFIG_INET6_IPCOMP=m
# CONFIG_IPV6_MIP6 is not set
CONFIG_INET6_XFRM_TUNNEL=m CONFIG_INET6_XFRM_TUNNEL=m
CONFIG_INET6_TUNNEL=m CONFIG_INET6_TUNNEL=m
CONFIG_INET6_XFRM_MODE_TRANSPORT=y CONFIG_INET6_XFRM_MODE_TRANSPORT=y
CONFIG_INET6_XFRM_MODE_TUNNEL=y CONFIG_INET6_XFRM_MODE_TUNNEL=y
# CONFIG_INET6_XFRM_MODE_ROUTEOPTIMIZATION is not set
CONFIG_IPV6_TUNNEL=m CONFIG_IPV6_TUNNEL=m
# CONFIG_IPV6_SUBTREES is not set
# CONFIG_IPV6_MULTIPLE_TABLES is not set
# CONFIG_NETWORK_SECMARK is not set # CONFIG_NETWORK_SECMARK is not set
CONFIG_NETFILTER=y CONFIG_NETFILTER=y
# CONFIG_NETFILTER_DEBUG is not set # CONFIG_NETFILTER_DEBUG is not set
...@@ -322,7 +335,6 @@ CONFIG_IP_NF_QUEUE=m ...@@ -322,7 +335,6 @@ CONFIG_IP_NF_QUEUE=m
# CONFIG_ATALK is not set # CONFIG_ATALK is not set
# CONFIG_X25 is not set # CONFIG_X25 is not set
# CONFIG_LAPB is not set # CONFIG_LAPB is not set
# CONFIG_NET_DIVERT is not set
# CONFIG_ECONET is not set # CONFIG_ECONET is not set
# CONFIG_WAN_ROUTER is not set # CONFIG_WAN_ROUTER is not set
...@@ -434,6 +446,7 @@ CONFIG_BLK_DEV_AEC62XX=y ...@@ -434,6 +446,7 @@ CONFIG_BLK_DEV_AEC62XX=y
# CONFIG_BLK_DEV_CS5530 is not set # CONFIG_BLK_DEV_CS5530 is not set
# CONFIG_BLK_DEV_HPT34X is not set # CONFIG_BLK_DEV_HPT34X is not set
# CONFIG_BLK_DEV_HPT366 is not set # CONFIG_BLK_DEV_HPT366 is not set
# CONFIG_BLK_DEV_JMICRON is not set
# CONFIG_BLK_DEV_SC1200 is not set # CONFIG_BLK_DEV_SC1200 is not set
# CONFIG_BLK_DEV_PIIX is not set # CONFIG_BLK_DEV_PIIX is not set
# CONFIG_BLK_DEV_IT821X is not set # CONFIG_BLK_DEV_IT821X is not set
...@@ -456,6 +469,12 @@ CONFIG_IDEDMA_AUTO=y ...@@ -456,6 +469,12 @@ CONFIG_IDEDMA_AUTO=y
# #
# CONFIG_RAID_ATTRS is not set # CONFIG_RAID_ATTRS is not set
# CONFIG_SCSI is not set # CONFIG_SCSI is not set
# CONFIG_SCSI_NETLINK is not set
#
# Serial ATA (prod) and Parallel ATA (experimental) drivers
#
# CONFIG_ATA is not set
# #
# Multi-device support (RAID and LVM) # Multi-device support (RAID and LVM)
...@@ -470,6 +489,7 @@ CONFIG_MD_RAID1=m ...@@ -470,6 +489,7 @@ CONFIG_MD_RAID1=m
# CONFIG_MD_MULTIPATH is not set # CONFIG_MD_MULTIPATH is not set
# CONFIG_MD_FAULTY is not set # CONFIG_MD_FAULTY is not set
CONFIG_BLK_DEV_DM=m CONFIG_BLK_DEV_DM=m
# CONFIG_DM_DEBUG is not set
CONFIG_DM_CRYPT=m CONFIG_DM_CRYPT=m
CONFIG_DM_SNAPSHOT=m CONFIG_DM_SNAPSHOT=m
CONFIG_DM_MIRROR=m CONFIG_DM_MIRROR=m
...@@ -504,7 +524,7 @@ CONFIG_NETDEVICES=y ...@@ -504,7 +524,7 @@ CONFIG_NETDEVICES=y
# CONFIG_DUMMY is not set # CONFIG_DUMMY is not set
CONFIG_BONDING=y CONFIG_BONDING=y
# CONFIG_EQUALIZER is not set # CONFIG_EQUALIZER is not set
# CONFIG_TUN is not set CONFIG_TUN=y
# #
# ARCnet devices # ARCnet devices
...@@ -552,7 +572,7 @@ CONFIG_SKGE=m ...@@ -552,7 +572,7 @@ CONFIG_SKGE=m
# CONFIG_TIGON3 is not set # CONFIG_TIGON3 is not set
# CONFIG_BNX2 is not set # CONFIG_BNX2 is not set
CONFIG_SPIDER_NET=m CONFIG_SPIDER_NET=m
# CONFIG_MV643XX_ETH is not set # CONFIG_QLA3XXX is not set
# #
# Ethernet (10000 Mbit) # Ethernet (10000 Mbit)
...@@ -599,6 +619,7 @@ CONFIG_SPIDER_NET=m ...@@ -599,6 +619,7 @@ CONFIG_SPIDER_NET=m
# Input device support # Input device support
# #
CONFIG_INPUT=y CONFIG_INPUT=y
# CONFIG_INPUT_FF_MEMLESS is not set
# #
# Userland interfaces # Userland interfaces
...@@ -865,6 +886,7 @@ CONFIG_INFINIBAND_USER_ACCESS=m ...@@ -865,6 +886,7 @@ CONFIG_INFINIBAND_USER_ACCESS=m
CONFIG_INFINIBAND_ADDR_TRANS=y CONFIG_INFINIBAND_ADDR_TRANS=y
CONFIG_INFINIBAND_MTHCA=m CONFIG_INFINIBAND_MTHCA=m
CONFIG_INFINIBAND_MTHCA_DEBUG=y CONFIG_INFINIBAND_MTHCA_DEBUG=y
# CONFIG_INFINIBAND_AMSO1100 is not set
CONFIG_INFINIBAND_IPOIB=m CONFIG_INFINIBAND_IPOIB=m
CONFIG_INFINIBAND_IPOIB_DEBUG=y CONFIG_INFINIBAND_IPOIB_DEBUG=y
CONFIG_INFINIBAND_IPOIB_DEBUG_DATA=y CONFIG_INFINIBAND_IPOIB_DEBUG_DATA=y
...@@ -916,7 +938,7 @@ CONFIG_INOTIFY_USER=y ...@@ -916,7 +938,7 @@ CONFIG_INOTIFY_USER=y
# CONFIG_QUOTA is not set # CONFIG_QUOTA is not set
CONFIG_DNOTIFY=y CONFIG_DNOTIFY=y
# CONFIG_AUTOFS_FS is not set # CONFIG_AUTOFS_FS is not set
# CONFIG_AUTOFS4_FS is not set CONFIG_AUTOFS4_FS=m
# CONFIG_FUSE_FS is not set # CONFIG_FUSE_FS is not set
# #
...@@ -943,8 +965,10 @@ CONFIG_FAT_DEFAULT_IOCHARSET="iso8859-1" ...@@ -943,8 +965,10 @@ CONFIG_FAT_DEFAULT_IOCHARSET="iso8859-1"
# #
CONFIG_PROC_FS=y CONFIG_PROC_FS=y
CONFIG_PROC_KCORE=y CONFIG_PROC_KCORE=y
CONFIG_PROC_SYSCTL=y
CONFIG_SYSFS=y CONFIG_SYSFS=y
CONFIG_TMPFS=y CONFIG_TMPFS=y
# CONFIG_TMPFS_POSIX_ACL is not set
CONFIG_HUGETLBFS=y CONFIG_HUGETLBFS=y
CONFIG_HUGETLB_PAGE=y CONFIG_HUGETLB_PAGE=y
CONFIG_RAMFS=y CONFIG_RAMFS=y
...@@ -1084,6 +1108,7 @@ CONFIG_PLIST=y ...@@ -1084,6 +1108,7 @@ CONFIG_PLIST=y
# Kernel hacking # Kernel hacking
# #
# CONFIG_PRINTK_TIME is not set # CONFIG_PRINTK_TIME is not set
# CONFIG_ENABLE_MUST_CHECK is not set
CONFIG_MAGIC_SYSRQ=y CONFIG_MAGIC_SYSRQ=y
# CONFIG_UNUSED_SYMBOLS is not set # CONFIG_UNUSED_SYMBOLS is not set
CONFIG_DEBUG_KERNEL=y CONFIG_DEBUG_KERNEL=y
...@@ -1102,6 +1127,7 @@ CONFIG_DEBUG_SPINLOCK_SLEEP=y ...@@ -1102,6 +1127,7 @@ CONFIG_DEBUG_SPINLOCK_SLEEP=y
# CONFIG_DEBUG_INFO is not set # CONFIG_DEBUG_INFO is not set
CONFIG_DEBUG_FS=y CONFIG_DEBUG_FS=y
# CONFIG_DEBUG_VM is not set # CONFIG_DEBUG_VM is not set
# CONFIG_DEBUG_LIST is not set
# CONFIG_FORCED_INLINING is not set # CONFIG_FORCED_INLINING is not set
# CONFIG_RCU_TORTURE_TEST is not set # CONFIG_RCU_TORTURE_TEST is not set
# CONFIG_DEBUG_STACKOVERFLOW is not set # CONFIG_DEBUG_STACKOVERFLOW is not set
...@@ -1123,6 +1149,10 @@ CONFIG_IRQSTACKS=y ...@@ -1123,6 +1149,10 @@ CONFIG_IRQSTACKS=y
# Cryptographic options # Cryptographic options
# #
CONFIG_CRYPTO=y CONFIG_CRYPTO=y
CONFIG_CRYPTO_ALGAPI=y
CONFIG_CRYPTO_BLKCIPHER=m
CONFIG_CRYPTO_HASH=y
# CONFIG_CRYPTO_MANAGER is not set
CONFIG_CRYPTO_HMAC=y CONFIG_CRYPTO_HMAC=y
# CONFIG_CRYPTO_NULL is not set # CONFIG_CRYPTO_NULL is not set
# CONFIG_CRYPTO_MD4 is not set # CONFIG_CRYPTO_MD4 is not set
...@@ -1132,6 +1162,8 @@ CONFIG_CRYPTO_SHA1=m ...@@ -1132,6 +1162,8 @@ CONFIG_CRYPTO_SHA1=m
# CONFIG_CRYPTO_SHA512 is not set # CONFIG_CRYPTO_SHA512 is not set
# CONFIG_CRYPTO_WP512 is not set # CONFIG_CRYPTO_WP512 is not set
# CONFIG_CRYPTO_TGR192 is not set # CONFIG_CRYPTO_TGR192 is not set
CONFIG_CRYPTO_ECB=m
CONFIG_CRYPTO_CBC=m
CONFIG_CRYPTO_DES=m CONFIG_CRYPTO_DES=m
# CONFIG_CRYPTO_BLOWFISH is not set # CONFIG_CRYPTO_BLOWFISH is not set
# CONFIG_CRYPTO_TWOFISH is not set # CONFIG_CRYPTO_TWOFISH is not set
......
...@@ -16,11 +16,6 @@ config SPU_BASE ...@@ -16,11 +16,6 @@ config SPU_BASE
bool bool
default n default n
config SPUFS_MMAP
bool
depends on SPU_FS && SPARSEMEM
default y
config CBE_RAS config CBE_RAS
bool "RAS features for bare metal Cell BE" bool "RAS features for bare metal Cell BE"
default y default y
......
...@@ -101,7 +101,7 @@ static void iic_ioexc_eoi(unsigned int irq) ...@@ -101,7 +101,7 @@ static void iic_ioexc_eoi(unsigned int irq)
static void iic_ioexc_cascade(unsigned int irq, struct irq_desc *desc, static void iic_ioexc_cascade(unsigned int irq, struct irq_desc *desc,
struct pt_regs *regs) struct pt_regs *regs)
{ {
struct cbe_iic_regs *node_iic = desc->handler_data; struct cbe_iic_regs __iomem *node_iic = (void __iomem *)desc->handler_data;
unsigned int base = (irq & 0xffffff00) | IIC_IRQ_TYPE_IOEXC; unsigned int base = (irq & 0xffffff00) | IIC_IRQ_TYPE_IOEXC;
unsigned long bits, ack; unsigned long bits, ack;
int cascade; int cascade;
...@@ -320,7 +320,7 @@ static int __init setup_iic(void) ...@@ -320,7 +320,7 @@ static int __init setup_iic(void)
struct device_node *dn; struct device_node *dn;
struct resource r0, r1; struct resource r0, r1;
unsigned int node, cascade, found = 0; unsigned int node, cascade, found = 0;
struct cbe_iic_regs *node_iic; struct cbe_iic_regs __iomem *node_iic;
const u32 *np; const u32 *np;
for (dn = NULL; for (dn = NULL;
...@@ -357,7 +357,11 @@ static int __init setup_iic(void) ...@@ -357,7 +357,11 @@ static int __init setup_iic(void)
cascade = irq_create_mapping(iic_host, cascade); cascade = irq_create_mapping(iic_host, cascade);
if (cascade == NO_IRQ) if (cascade == NO_IRQ)
continue; continue;
set_irq_data(cascade, node_iic); /*
* irq_data is a generic pointer that gets passed back
* to us later, so the forced cast is fine.
*/
set_irq_data(cascade, (void __force *)node_iic);
set_irq_chained_handler(cascade , iic_ioexc_cascade); set_irq_chained_handler(cascade , iic_ioexc_cascade);
out_be64(&node_iic->iic_ir, out_be64(&node_iic->iic_ir,
(1 << 12) /* priority */ | (1 << 12) /* priority */ |
......
...@@ -345,8 +345,8 @@ static int cell_map_iommu_hardcoded(int num_nodes) ...@@ -345,8 +345,8 @@ static int cell_map_iommu_hardcoded(int num_nodes)
/* node 0 */ /* node 0 */
iommu = &cell_iommus[0]; iommu = &cell_iommus[0];
iommu->mapped_base = ioremap(0x20000511000, 0x1000); iommu->mapped_base = ioremap(0x20000511000ul, 0x1000);
iommu->mapped_mmio_base = ioremap(0x20000510000, 0x1000); iommu->mapped_mmio_base = ioremap(0x20000510000ul, 0x1000);
enable_mapping(iommu->mapped_base, iommu->mapped_mmio_base); enable_mapping(iommu->mapped_base, iommu->mapped_mmio_base);
...@@ -358,8 +358,8 @@ static int cell_map_iommu_hardcoded(int num_nodes) ...@@ -358,8 +358,8 @@ static int cell_map_iommu_hardcoded(int num_nodes)
/* node 1 */ /* node 1 */
iommu = &cell_iommus[1]; iommu = &cell_iommus[1];
iommu->mapped_base = ioremap(0x30000511000, 0x1000); iommu->mapped_base = ioremap(0x30000511000ul, 0x1000);
iommu->mapped_mmio_base = ioremap(0x30000510000, 0x1000); iommu->mapped_mmio_base = ioremap(0x30000510000ul, 0x1000);
enable_mapping(iommu->mapped_base, iommu->mapped_mmio_base); enable_mapping(iommu->mapped_base, iommu->mapped_mmio_base);
......
...@@ -244,7 +244,6 @@ static unsigned int __init spider_find_cascade_and_node(struct spider_pic *pic) ...@@ -244,7 +244,6 @@ static unsigned int __init spider_find_cascade_and_node(struct spider_pic *pic)
int imaplen, intsize, unit; int imaplen, intsize, unit;
struct device_node *iic; struct device_node *iic;
#if 0 /* Enable that when we have a way to retreive the node as well */
/* First, we check wether we have a real "interrupts" in the device /* First, we check wether we have a real "interrupts" in the device
* tree in case the device-tree is ever fixed * tree in case the device-tree is ever fixed
*/ */
...@@ -252,9 +251,8 @@ static unsigned int __init spider_find_cascade_and_node(struct spider_pic *pic) ...@@ -252,9 +251,8 @@ static unsigned int __init spider_find_cascade_and_node(struct spider_pic *pic)
if (of_irq_map_one(pic->of_node, 0, &oirq) == 0) { if (of_irq_map_one(pic->of_node, 0, &oirq) == 0) {
virq = irq_create_of_mapping(oirq.controller, oirq.specifier, virq = irq_create_of_mapping(oirq.controller, oirq.specifier,
oirq.size); oirq.size);
goto bail; return virq;
} }
#endif
/* Now do the horrible hacks */ /* Now do the horrible hacks */
tmp = get_property(pic->of_node, "#interrupt-cells", NULL); tmp = get_property(pic->of_node, "#interrupt-cells", NULL);
...@@ -369,7 +367,7 @@ void __init spider_init_IRQ(void) ...@@ -369,7 +367,7 @@ void __init spider_init_IRQ(void)
} else if (device_is_compatible(dn, "sti,platform-spider-pic") } else if (device_is_compatible(dn, "sti,platform-spider-pic")
&& (chip < 2)) { && (chip < 2)) {
static long hard_coded_pics[] = static long hard_coded_pics[] =
{ 0x24000008000, 0x34000008000 }; { 0x24000008000ul, 0x34000008000ul};
r.start = hard_coded_pics[chip]; r.start = hard_coded_pics[chip];
} else } else
continue; continue;
......
...@@ -25,11 +25,13 @@ ...@@ -25,11 +25,13 @@
#include <linux/interrupt.h> #include <linux/interrupt.h>
#include <linux/list.h> #include <linux/list.h>
#include <linux/module.h> #include <linux/module.h>
#include <linux/pci.h>
#include <linux/poll.h> #include <linux/poll.h>
#include <linux/ptrace.h> #include <linux/ptrace.h>
#include <linux/slab.h> #include <linux/slab.h>
#include <linux/wait.h> #include <linux/wait.h>
#include <asm/firmware.h>
#include <asm/io.h> #include <asm/io.h>
#include <asm/prom.h> #include <asm/prom.h>
#include <linux/mutex.h> #include <linux/mutex.h>
...@@ -46,21 +48,21 @@ EXPORT_SYMBOL_GPL(spu_priv1_ops); ...@@ -46,21 +48,21 @@ EXPORT_SYMBOL_GPL(spu_priv1_ops);
static int __spu_trap_invalid_dma(struct spu *spu) static int __spu_trap_invalid_dma(struct spu *spu)
{ {
pr_debug("%s\n", __FUNCTION__); pr_debug("%s\n", __FUNCTION__);
force_sig(SIGBUS, /* info, */ current); spu->dma_callback(spu, SPE_EVENT_INVALID_DMA);
return 0; return 0;
} }
static int __spu_trap_dma_align(struct spu *spu) static int __spu_trap_dma_align(struct spu *spu)
{ {
pr_debug("%s\n", __FUNCTION__); pr_debug("%s\n", __FUNCTION__);
force_sig(SIGBUS, /* info, */ current); spu->dma_callback(spu, SPE_EVENT_DMA_ALIGNMENT);
return 0; return 0;
} }
static int __spu_trap_error(struct spu *spu) static int __spu_trap_error(struct spu *spu)
{ {
pr_debug("%s\n", __FUNCTION__); pr_debug("%s\n", __FUNCTION__);
force_sig(SIGILL, /* info, */ current); spu->dma_callback(spu, SPE_EVENT_SPE_ERROR);
return 0; return 0;
} }
...@@ -317,7 +319,7 @@ static void spu_free_irqs(struct spu *spu) ...@@ -317,7 +319,7 @@ static void spu_free_irqs(struct spu *spu)
free_irq(spu->irqs[2], spu); free_irq(spu->irqs[2], spu);
} }
static LIST_HEAD(spu_list); static struct list_head spu_list[MAX_NUMNODES];
static DEFINE_MUTEX(spu_mutex); static DEFINE_MUTEX(spu_mutex);
static void spu_init_channels(struct spu *spu) static void spu_init_channels(struct spu *spu)
...@@ -354,32 +356,42 @@ static void spu_init_channels(struct spu *spu) ...@@ -354,32 +356,42 @@ static void spu_init_channels(struct spu *spu)
} }
} }
struct spu *spu_alloc(void) struct spu *spu_alloc_node(int node)
{ {
struct spu *spu; struct spu *spu = NULL;
mutex_lock(&spu_mutex); mutex_lock(&spu_mutex);
if (!list_empty(&spu_list)) { if (!list_empty(&spu_list[node])) {
spu = list_entry(spu_list.next, struct spu, list); spu = list_entry(spu_list[node].next, struct spu, list);
list_del_init(&spu->list); list_del_init(&spu->list);
pr_debug("Got SPU %x %d\n", spu->isrc, spu->number); pr_debug("Got SPU %x %d %d\n",
} else { spu->isrc, spu->number, spu->node);
pr_debug("No SPU left\n"); spu_init_channels(spu);
spu = NULL;
} }
mutex_unlock(&spu_mutex); mutex_unlock(&spu_mutex);
if (spu) return spu;
spu_init_channels(spu); }
EXPORT_SYMBOL_GPL(spu_alloc_node);
struct spu *spu_alloc(void)
{
struct spu *spu = NULL;
int node;
for (node = 0; node < MAX_NUMNODES; node++) {
spu = spu_alloc_node(node);
if (spu)
break;
}
return spu; return spu;
} }
EXPORT_SYMBOL_GPL(spu_alloc);
void spu_free(struct spu *spu) void spu_free(struct spu *spu)
{ {
mutex_lock(&spu_mutex); mutex_lock(&spu_mutex);
list_add_tail(&spu->list, &spu_list); list_add_tail(&spu->list, &spu_list[spu->node]);
mutex_unlock(&spu_mutex); mutex_unlock(&spu_mutex);
} }
EXPORT_SYMBOL_GPL(spu_free); EXPORT_SYMBOL_GPL(spu_free);
...@@ -566,7 +578,7 @@ static void spu_unmap(struct spu *spu) ...@@ -566,7 +578,7 @@ static void spu_unmap(struct spu *spu)
} }
/* This function shall be abstracted for HV platforms */ /* This function shall be abstracted for HV platforms */
static int __init spu_map_interrupts(struct spu *spu, struct device_node *np) static int __init spu_map_interrupts_old(struct spu *spu, struct device_node *np)
{ {
unsigned int isrc; unsigned int isrc;
const u32 *tmp; const u32 *tmp;
...@@ -590,7 +602,7 @@ static int __init spu_map_interrupts(struct spu *spu, struct device_node *np) ...@@ -590,7 +602,7 @@ static int __init spu_map_interrupts(struct spu *spu, struct device_node *np)
return spu->irqs[2] == NO_IRQ ? -EINVAL : 0; return spu->irqs[2] == NO_IRQ ? -EINVAL : 0;
} }
static int __init spu_map_device(struct spu *spu, struct device_node *node) static int __init spu_map_device_old(struct spu *spu, struct device_node *node)
{ {
const char *prop; const char *prop;
int ret; int ret;
...@@ -635,6 +647,88 @@ out: ...@@ -635,6 +647,88 @@ out:
return ret; return ret;
} }
static int __init spu_map_interrupts(struct spu *spu, struct device_node *np)
{
struct of_irq oirq;
int ret;
int i;
for (i=0; i < 3; i++) {
ret = of_irq_map_one(np, i, &oirq);
if (ret)
goto err;
ret = -EINVAL;
spu->irqs[i] = irq_create_of_mapping(oirq.controller,
oirq.specifier, oirq.size);
if (spu->irqs[i] == NO_IRQ)
goto err;
}
return 0;
err:
pr_debug("failed to map irq %x for spu %s\n", *oirq.specifier, spu->name);
for (; i >= 0; i--) {
if (spu->irqs[i] != NO_IRQ)
irq_dispose_mapping(spu->irqs[i]);
}
return ret;
}
static int spu_map_resource(struct device_node *node, int nr,
void __iomem** virt, unsigned long *phys)
{
struct resource resource = { };
int ret;
ret = of_address_to_resource(node, 0, &resource);
if (ret)
goto out;
if (phys)
*phys = resource.start;
*virt = ioremap(resource.start, resource.end - resource.start);
if (!*virt)
ret = -EINVAL;
out:
return ret;
}
static int __init spu_map_device(struct spu *spu, struct device_node *node)
{
int ret = -ENODEV;
spu->name = get_property(node, "name", NULL);
if (!spu->name)
goto out;
ret = spu_map_resource(node, 0, (void __iomem**)&spu->local_store,
&spu->local_store_phys);
if (ret)
goto out;
ret = spu_map_resource(node, 1, (void __iomem**)&spu->problem,
&spu->problem_phys);
if (ret)
goto out_unmap;
ret = spu_map_resource(node, 2, (void __iomem**)&spu->priv2,
NULL);
if (ret)
goto out_unmap;
if (!firmware_has_feature(FW_FEATURE_LPAR))
ret = spu_map_resource(node, 3, (void __iomem**)&spu->priv1,
NULL);
if (ret)
goto out_unmap;
return 0;
out_unmap:
spu_unmap(spu);
out:
pr_debug("failed to map spe %s: %d\n", spu->name, ret);
return ret;
}
struct sysdev_class spu_sysdev_class = { struct sysdev_class spu_sysdev_class = {
set_kset_name("spu") set_kset_name("spu")
}; };
...@@ -688,6 +782,9 @@ static int __init create_spu(struct device_node *spe) ...@@ -688,6 +782,9 @@ static int __init create_spu(struct device_node *spe)
goto out; goto out;
ret = spu_map_device(spu, spe); ret = spu_map_device(spu, spe);
/* try old method */
if (ret)
ret = spu_map_device_old(spu, spe);
if (ret) if (ret)
goto out_free; goto out_free;
...@@ -696,6 +793,8 @@ static int __init create_spu(struct device_node *spe) ...@@ -696,6 +793,8 @@ static int __init create_spu(struct device_node *spe)
if (spu->nid == -1) if (spu->nid == -1)
spu->nid = 0; spu->nid = 0;
ret = spu_map_interrupts(spu, spe); ret = spu_map_interrupts(spu, spe);
if (ret)
ret = spu_map_interrupts_old(spu, spe);
if (ret) if (ret)
goto out_unmap; goto out_unmap;
spin_lock_init(&spu->register_lock); spin_lock_init(&spu->register_lock);
...@@ -706,13 +805,13 @@ static int __init create_spu(struct device_node *spe) ...@@ -706,13 +805,13 @@ static int __init create_spu(struct device_node *spe)
spu->number = number++; spu->number = number++;
ret = spu_request_irqs(spu); ret = spu_request_irqs(spu);
if (ret) if (ret)
goto out_unmap; goto out_unlock;
ret = spu_create_sysdev(spu); ret = spu_create_sysdev(spu);
if (ret) if (ret)
goto out_free_irqs; goto out_free_irqs;
list_add(&spu->list, &spu_list); list_add(&spu->list, &spu_list[spu->node]);
mutex_unlock(&spu_mutex); mutex_unlock(&spu_mutex);
pr_debug(KERN_DEBUG "Using SPE %s %02x %p %p %p %p %d\n", pr_debug(KERN_DEBUG "Using SPE %s %02x %p %p %p %p %d\n",
...@@ -722,9 +821,9 @@ static int __init create_spu(struct device_node *spe) ...@@ -722,9 +821,9 @@ static int __init create_spu(struct device_node *spe)
out_free_irqs: out_free_irqs:
spu_free_irqs(spu); spu_free_irqs(spu);
out_unlock:
out_unmap:
mutex_unlock(&spu_mutex); mutex_unlock(&spu_mutex);
out_unmap:
spu_unmap(spu); spu_unmap(spu);
out_free: out_free:
kfree(spu); kfree(spu);
...@@ -745,9 +844,13 @@ static void destroy_spu(struct spu *spu) ...@@ -745,9 +844,13 @@ static void destroy_spu(struct spu *spu)
static void cleanup_spu_base(void) static void cleanup_spu_base(void)
{ {
struct spu *spu, *tmp; struct spu *spu, *tmp;
int node;
mutex_lock(&spu_mutex); mutex_lock(&spu_mutex);
list_for_each_entry_safe(spu, tmp, &spu_list, list) for (node = 0; node < MAX_NUMNODES; node++) {
destroy_spu(spu); list_for_each_entry_safe(spu, tmp, &spu_list[node], list)
destroy_spu(spu);
}
mutex_unlock(&spu_mutex); mutex_unlock(&spu_mutex);
sysdev_class_unregister(&spu_sysdev_class); sysdev_class_unregister(&spu_sysdev_class);
} }
...@@ -756,13 +859,16 @@ module_exit(cleanup_spu_base); ...@@ -756,13 +859,16 @@ module_exit(cleanup_spu_base);
static int __init init_spu_base(void) static int __init init_spu_base(void)
{ {
struct device_node *node; struct device_node *node;
int ret; int i, ret;
/* create sysdev class for spus */ /* create sysdev class for spus */
ret = sysdev_class_register(&spu_sysdev_class); ret = sysdev_class_register(&spu_sysdev_class);
if (ret) if (ret)
return ret; return ret;
for (i = 0; i < MAX_NUMNODES; i++)
INIT_LIST_HEAD(&spu_list[i]);
ret = -ENODEV; ret = -ENODEV;
for (node = of_find_node_by_type(NULL, "spe"); for (node = of_find_node_by_type(NULL, "spe");
node; node = of_find_node_by_type(node, "spe")) { node; node = of_find_node_by_type(node, "spe")) {
...@@ -774,18 +880,6 @@ static int __init init_spu_base(void) ...@@ -774,18 +880,6 @@ static int __init init_spu_base(void)
break; break;
} }
} }
/* in some old firmware versions, the spe is called 'spc', so we
look for that as well */
for (node = of_find_node_by_type(NULL, "spc");
node; node = of_find_node_by_type(node, "spc")) {
ret = create_spu(node);
if (ret) {
printk(KERN_WARNING "%s: Error initializing %s\n",
__FUNCTION__, node->name);
cleanup_spu_base();
break;
}
}
return ret; return ret;
} }
module_init(init_spu_base); module_init(init_spu_base);
......
...@@ -2,7 +2,7 @@ obj-y += switch.o ...@@ -2,7 +2,7 @@ obj-y += switch.o
obj-$(CONFIG_SPU_FS) += spufs.o obj-$(CONFIG_SPU_FS) += spufs.o
spufs-y += inode.o file.o context.o syscalls.o spufs-y += inode.o file.o context.o syscalls.o
spufs-y += sched.o backing_ops.o hw_ops.o run.o spufs-y += sched.o backing_ops.o hw_ops.o run.o gang.o
# Rules to build switch.o with the help of SPU tool chain # Rules to build switch.o with the help of SPU tool chain
SPU_CROSS := spu- SPU_CROSS := spu-
......
...@@ -27,7 +27,7 @@ ...@@ -27,7 +27,7 @@
#include <asm/spu_csa.h> #include <asm/spu_csa.h>
#include "spufs.h" #include "spufs.h"
struct spu_context *alloc_spu_context(void) struct spu_context *alloc_spu_context(struct spu_gang *gang)
{ {
struct spu_context *ctx; struct spu_context *ctx;
ctx = kzalloc(sizeof *ctx, GFP_KERNEL); ctx = kzalloc(sizeof *ctx, GFP_KERNEL);
...@@ -51,6 +51,8 @@ struct spu_context *alloc_spu_context(void) ...@@ -51,6 +51,8 @@ struct spu_context *alloc_spu_context(void)
ctx->state = SPU_STATE_SAVED; ctx->state = SPU_STATE_SAVED;
ctx->ops = &spu_backing_ops; ctx->ops = &spu_backing_ops;
ctx->owner = get_task_mm(current); ctx->owner = get_task_mm(current);
if (gang)
spu_gang_add_ctx(gang, ctx);
goto out; goto out;
out_free: out_free:
kfree(ctx); kfree(ctx);
...@@ -67,6 +69,8 @@ void destroy_spu_context(struct kref *kref) ...@@ -67,6 +69,8 @@ void destroy_spu_context(struct kref *kref)
spu_deactivate(ctx); spu_deactivate(ctx);
up_write(&ctx->state_sema); up_write(&ctx->state_sema);
spu_fini_csa(&ctx->csa); spu_fini_csa(&ctx->csa);
if (ctx->gang)
spu_gang_remove_ctx(ctx->gang, ctx);
kfree(ctx); kfree(ctx);
} }
......
This diff is collapsed.
/*
* SPU file system
*
* (C) Copyright IBM Deutschland Entwicklung GmbH 2005
*
* Author: Arnd Bergmann <arndb@de.ibm.com>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2, or (at your option)
* any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
*/
#include <linux/list.h>
#include <linux/slab.h>
#include "spufs.h"
struct spu_gang *alloc_spu_gang(void)
{
struct spu_gang *gang;
gang = kzalloc(sizeof *gang, GFP_KERNEL);
if (!gang)
goto out;
kref_init(&gang->kref);
mutex_init(&gang->mutex);
INIT_LIST_HEAD(&gang->list);
out:
return gang;
}
static void destroy_spu_gang(struct kref *kref)
{
struct spu_gang *gang;
gang = container_of(kref, struct spu_gang, kref);
WARN_ON(gang->contexts || !list_empty(&gang->list));
kfree(gang);
}
struct spu_gang *get_spu_gang(struct spu_gang *gang)
{
kref_get(&gang->kref);
return gang;
}
int put_spu_gang(struct spu_gang *gang)
{
return kref_put(&gang->kref, &destroy_spu_gang);
}
void spu_gang_add_ctx(struct spu_gang *gang, struct spu_context *ctx)
{
mutex_lock(&gang->mutex);
ctx->gang = get_spu_gang(gang);
list_add(&ctx->gang_list, &gang->list);
gang->contexts++;
mutex_unlock(&gang->mutex);
}
void spu_gang_remove_ctx(struct spu_gang *gang, struct spu_context *ctx)
{
mutex_lock(&gang->mutex);
WARN_ON(ctx->gang != gang);
list_del_init(&ctx->gang_list);
gang->contexts--;
mutex_unlock(&gang->mutex);
put_spu_gang(gang);
}
...@@ -50,6 +50,10 @@ spufs_alloc_inode(struct super_block *sb) ...@@ -50,6 +50,10 @@ spufs_alloc_inode(struct super_block *sb)
ei = kmem_cache_alloc(spufs_inode_cache, SLAB_KERNEL); ei = kmem_cache_alloc(spufs_inode_cache, SLAB_KERNEL);
if (!ei) if (!ei)
return NULL; return NULL;
ei->i_gang = NULL;
ei->i_ctx = NULL;
return &ei->vfs_inode; return &ei->vfs_inode;
} }
...@@ -128,14 +132,19 @@ out: ...@@ -128,14 +132,19 @@ out:
static void static void
spufs_delete_inode(struct inode *inode) spufs_delete_inode(struct inode *inode)
{ {
if (SPUFS_I(inode)->i_ctx) struct spufs_inode_info *ei = SPUFS_I(inode);
put_spu_context(SPUFS_I(inode)->i_ctx);
if (ei->i_ctx)
put_spu_context(ei->i_ctx);
if (ei->i_gang)
put_spu_gang(ei->i_gang);
clear_inode(inode); clear_inode(inode);
} }
static void spufs_prune_dir(struct dentry *dir) static void spufs_prune_dir(struct dentry *dir)
{ {
struct dentry *dentry, *tmp; struct dentry *dentry, *tmp;
mutex_lock(&dir->d_inode->i_mutex); mutex_lock(&dir->d_inode->i_mutex);
list_for_each_entry_safe(dentry, tmp, &dir->d_subdirs, d_u.d_child) { list_for_each_entry_safe(dentry, tmp, &dir->d_subdirs, d_u.d_child) {
spin_lock(&dcache_lock); spin_lock(&dcache_lock);
...@@ -156,13 +165,13 @@ static void spufs_prune_dir(struct dentry *dir) ...@@ -156,13 +165,13 @@ static void spufs_prune_dir(struct dentry *dir)
mutex_unlock(&dir->d_inode->i_mutex); mutex_unlock(&dir->d_inode->i_mutex);
} }
/* Caller must hold root->i_mutex */ /* Caller must hold parent->i_mutex */
static int spufs_rmdir(struct inode *root, struct dentry *dir_dentry) static int spufs_rmdir(struct inode *parent, struct dentry *dir)
{ {
/* remove all entries */ /* remove all entries */
spufs_prune_dir(dir_dentry); spufs_prune_dir(dir);
return simple_rmdir(root, dir_dentry); return simple_rmdir(parent, dir);
} }
static int spufs_fill_dir(struct dentry *dir, struct tree_descr *files, static int spufs_fill_dir(struct dentry *dir, struct tree_descr *files,
...@@ -191,17 +200,17 @@ out: ...@@ -191,17 +200,17 @@ out:
static int spufs_dir_close(struct inode *inode, struct file *file) static int spufs_dir_close(struct inode *inode, struct file *file)
{ {
struct spu_context *ctx; struct spu_context *ctx;
struct inode *dir; struct inode *parent;
struct dentry *dentry; struct dentry *dir;
int ret; int ret;
dentry = file->f_dentry; dir = file->f_dentry;
dir = dentry->d_parent->d_inode; parent = dir->d_parent->d_inode;
ctx = SPUFS_I(dentry->d_inode)->i_ctx; ctx = SPUFS_I(dir->d_inode)->i_ctx;
mutex_lock(&dir->i_mutex); mutex_lock(&parent->i_mutex);
ret = spufs_rmdir(dir, dentry); ret = spufs_rmdir(parent, dir);
mutex_unlock(&dir->i_mutex); mutex_unlock(&parent->i_mutex);
WARN_ON(ret); WARN_ON(ret);
/* We have to give up the mm_struct */ /* We have to give up the mm_struct */
...@@ -224,7 +233,8 @@ struct file_operations spufs_context_fops = { ...@@ -224,7 +233,8 @@ struct file_operations spufs_context_fops = {
}; };
static int static int
spufs_mkdir(struct inode *dir, struct dentry *dentry, int mode) spufs_mkdir(struct inode *dir, struct dentry *dentry, unsigned int flags,
int mode)
{ {
int ret; int ret;
struct inode *inode; struct inode *inode;
...@@ -239,11 +249,13 @@ spufs_mkdir(struct inode *dir, struct dentry *dentry, int mode) ...@@ -239,11 +249,13 @@ spufs_mkdir(struct inode *dir, struct dentry *dentry, int mode)
inode->i_gid = dir->i_gid; inode->i_gid = dir->i_gid;
inode->i_mode &= S_ISGID; inode->i_mode &= S_ISGID;
} }
ctx = alloc_spu_context(); ctx = alloc_spu_context(SPUFS_I(dir)->i_gang); /* XXX gang */
SPUFS_I(inode)->i_ctx = ctx; SPUFS_I(inode)->i_ctx = ctx;
if (!ctx) if (!ctx)
goto out_iput; goto out_iput;
ctx->flags = flags;
inode->i_op = &spufs_dir_inode_operations; inode->i_op = &spufs_dir_inode_operations;
inode->i_fop = &simple_dir_operations; inode->i_fop = &simple_dir_operations;
ret = spufs_fill_dir(dentry, spufs_dir_contents, mode, ctx); ret = spufs_fill_dir(dentry, spufs_dir_contents, mode, ctx);
...@@ -289,24 +301,177 @@ out: ...@@ -289,24 +301,177 @@ out:
return ret; return ret;
} }
static int spufs_create_context(struct inode *inode,
struct dentry *dentry,
struct vfsmount *mnt, int flags, int mode)
{
int ret;
ret = spufs_mkdir(inode, dentry, flags, mode & S_IRWXUGO);
if (ret)
goto out_unlock;
/*
* get references for dget and mntget, will be released
* in error path of *_open().
*/
ret = spufs_context_open(dget(dentry), mntget(mnt));
if (ret < 0) {
WARN_ON(spufs_rmdir(inode, dentry));
mutex_unlock(&inode->i_mutex);
spu_forget(SPUFS_I(dentry->d_inode)->i_ctx);
goto out;
}
out_unlock:
mutex_unlock(&inode->i_mutex);
out:
dput(dentry);
return ret;
}
static int spufs_rmgang(struct inode *root, struct dentry *dir)
{
/* FIXME: this fails if the dir is not empty,
which causes a leak of gangs. */
return simple_rmdir(root, dir);
}
static int spufs_gang_close(struct inode *inode, struct file *file)
{
struct inode *parent;
struct dentry *dir;
int ret;
dir = file->f_dentry;
parent = dir->d_parent->d_inode;
ret = spufs_rmgang(parent, dir);
WARN_ON(ret);
return dcache_dir_close(inode, file);
}
struct file_operations spufs_gang_fops = {
.open = dcache_dir_open,
.release = spufs_gang_close,
.llseek = dcache_dir_lseek,
.read = generic_read_dir,
.readdir = dcache_readdir,
.fsync = simple_sync_file,
};
static int
spufs_mkgang(struct inode *dir, struct dentry *dentry, int mode)
{
int ret;
struct inode *inode;
struct spu_gang *gang;
ret = -ENOSPC;
inode = spufs_new_inode(dir->i_sb, mode | S_IFDIR);
if (!inode)
goto out;
ret = 0;
if (dir->i_mode & S_ISGID) {
inode->i_gid = dir->i_gid;
inode->i_mode &= S_ISGID;
}
gang = alloc_spu_gang();
SPUFS_I(inode)->i_ctx = NULL;
SPUFS_I(inode)->i_gang = gang;
if (!gang)
goto out_iput;
inode->i_op = &spufs_dir_inode_operations;
inode->i_fop = &simple_dir_operations;
d_instantiate(dentry, inode);
dget(dentry);
dir->i_nlink++;
dentry->d_inode->i_nlink++;
return ret;
out_iput:
iput(inode);
out:
return ret;
}
static int spufs_gang_open(struct dentry *dentry, struct vfsmount *mnt)
{
int ret;
struct file *filp;
ret = get_unused_fd();
if (ret < 0) {
dput(dentry);
mntput(mnt);
goto out;
}
filp = dentry_open(dentry, mnt, O_RDONLY);
if (IS_ERR(filp)) {
put_unused_fd(ret);
ret = PTR_ERR(filp);
goto out;
}
filp->f_op = &spufs_gang_fops;
fd_install(ret, filp);
out:
return ret;
}
static int spufs_create_gang(struct inode *inode,
struct dentry *dentry,
struct vfsmount *mnt, int mode)
{
int ret;
ret = spufs_mkgang(inode, dentry, mode & S_IRWXUGO);
if (ret)
goto out;
/*
* get references for dget and mntget, will be released
* in error path of *_open().
*/
ret = spufs_gang_open(dget(dentry), mntget(mnt));
if (ret < 0)
WARN_ON(spufs_rmgang(inode, dentry));
out:
mutex_unlock(&inode->i_mutex);
dput(dentry);
return ret;
}
static struct file_system_type spufs_type; static struct file_system_type spufs_type;
long spufs_create_thread(struct nameidata *nd, long spufs_create(struct nameidata *nd, unsigned int flags, mode_t mode)
unsigned int flags, mode_t mode)
{ {
struct dentry *dentry; struct dentry *dentry;
int ret; int ret;
/* need to be at the root of spufs */
ret = -EINVAL; ret = -EINVAL;
if (nd->dentry->d_sb->s_type != &spufs_type || /* check if we are on spufs */
nd->dentry != nd->dentry->d_sb->s_root) if (nd->dentry->d_sb->s_type != &spufs_type)
goto out; goto out;
/* all flags are reserved */ /* don't accept undefined flags */
if (flags) if (flags & (~SPU_CREATE_FLAG_ALL))
goto out; goto out;
/* only threads can be underneath a gang */
if (nd->dentry != nd->dentry->d_sb->s_root) {
if ((flags & SPU_CREATE_GANG) ||
!SPUFS_I(nd->dentry->d_inode)->i_gang)
goto out;
}
dentry = lookup_create(nd, 1); dentry = lookup_create(nd, 1);
ret = PTR_ERR(dentry); ret = PTR_ERR(dentry);
if (IS_ERR(dentry)) if (IS_ERR(dentry))
...@@ -317,22 +482,13 @@ long spufs_create_thread(struct nameidata *nd, ...@@ -317,22 +482,13 @@ long spufs_create_thread(struct nameidata *nd,
goto out_dput; goto out_dput;
mode &= ~current->fs->umask; mode &= ~current->fs->umask;
ret = spufs_mkdir(nd->dentry->d_inode, dentry, mode & S_IRWXUGO);
if (ret)
goto out_dput;
/* if (flags & SPU_CREATE_GANG)
* get references for dget and mntget, will be released return spufs_create_gang(nd->dentry->d_inode,
* in error path of *_open(). dentry, nd->mnt, mode);
*/ else
ret = spufs_context_open(dget(dentry), mntget(nd->mnt)); return spufs_create_context(nd->dentry->d_inode,
if (ret < 0) { dentry, nd->mnt, flags, mode);
WARN_ON(spufs_rmdir(nd->dentry->d_inode, dentry));
mutex_unlock(&nd->dentry->d_inode->i_mutex);
spu_forget(SPUFS_I(dentry->d_inode)->i_ctx);
dput(dentry);
goto out;
}
out_dput: out_dput:
dput(dentry); dput(dentry);
......
...@@ -14,6 +14,26 @@ void spufs_stop_callback(struct spu *spu) ...@@ -14,6 +14,26 @@ void spufs_stop_callback(struct spu *spu)
wake_up_all(&ctx->stop_wq); wake_up_all(&ctx->stop_wq);
} }
void spufs_dma_callback(struct spu *spu, int type)
{
struct spu_context *ctx = spu->ctx;
if (ctx->flags & SPU_CREATE_EVENTS_ENABLED) {
ctx->event_return |= type;
wake_up_all(&ctx->stop_wq);
} else {
switch (type) {
case SPE_EVENT_DMA_ALIGNMENT:
case SPE_EVENT_INVALID_DMA:
force_sig(SIGBUS, /* info, */ current);
break;
case SPE_EVENT_SPE_ERROR:
force_sig(SIGILL, /* info */ current);
break;
}
}
}
static inline int spu_stopped(struct spu_context *ctx, u32 * stat) static inline int spu_stopped(struct spu_context *ctx, u32 * stat)
{ {
struct spu *spu; struct spu *spu;
...@@ -28,8 +48,7 @@ static inline int spu_stopped(struct spu_context *ctx, u32 * stat) ...@@ -28,8 +48,7 @@ static inline int spu_stopped(struct spu_context *ctx, u32 * stat)
return (!(*stat & 0x1) || pte_fault || spu->class_0_pending) ? 1 : 0; return (!(*stat & 0x1) || pte_fault || spu->class_0_pending) ? 1 : 0;
} }
static inline int spu_run_init(struct spu_context *ctx, u32 * npc, static inline int spu_run_init(struct spu_context *ctx, u32 * npc)
u32 * status)
{ {
int ret; int ret;
...@@ -72,7 +91,7 @@ static inline int spu_reacquire_runnable(struct spu_context *ctx, u32 *npc, ...@@ -72,7 +91,7 @@ static inline int spu_reacquire_runnable(struct spu_context *ctx, u32 *npc,
SPU_STATUS_STOPPED_BY_HALT)) { SPU_STATUS_STOPPED_BY_HALT)) {
return *status; return *status;
} }
if ((ret = spu_run_init(ctx, npc, status)) != 0) if ((ret = spu_run_init(ctx, npc)) != 0)
return ret; return ret;
return 0; return 0;
} }
...@@ -177,46 +196,49 @@ static inline int spu_process_events(struct spu_context *ctx) ...@@ -177,46 +196,49 @@ static inline int spu_process_events(struct spu_context *ctx)
} }
long spufs_run_spu(struct file *file, struct spu_context *ctx, long spufs_run_spu(struct file *file, struct spu_context *ctx,
u32 * npc, u32 * status) u32 *npc, u32 *event)
{ {
int ret; int ret;
u32 status;
if (down_interruptible(&ctx->run_sema)) if (down_interruptible(&ctx->run_sema))
return -ERESTARTSYS; return -ERESTARTSYS;
ret = spu_run_init(ctx, npc, status); ctx->event_return = 0;
ret = spu_run_init(ctx, npc);
if (ret) if (ret)
goto out; goto out;
do { do {
ret = spufs_wait(ctx->stop_wq, spu_stopped(ctx, status)); ret = spufs_wait(ctx->stop_wq, spu_stopped(ctx, &status));
if (unlikely(ret)) if (unlikely(ret))
break; break;
if ((*status & SPU_STATUS_STOPPED_BY_STOP) && if ((status & SPU_STATUS_STOPPED_BY_STOP) &&
(*status >> SPU_STOP_STATUS_SHIFT == 0x2104)) { (status >> SPU_STOP_STATUS_SHIFT == 0x2104)) {
ret = spu_process_callback(ctx); ret = spu_process_callback(ctx);
if (ret) if (ret)
break; break;
*status &= ~SPU_STATUS_STOPPED_BY_STOP; status &= ~SPU_STATUS_STOPPED_BY_STOP;
} }
if (unlikely(ctx->state != SPU_STATE_RUNNABLE)) { if (unlikely(ctx->state != SPU_STATE_RUNNABLE)) {
ret = spu_reacquire_runnable(ctx, npc, status); ret = spu_reacquire_runnable(ctx, npc, &status);
if (ret) if (ret)
goto out; goto out;
continue; continue;
} }
ret = spu_process_events(ctx); ret = spu_process_events(ctx);
} while (!ret && !(*status & (SPU_STATUS_STOPPED_BY_STOP | } while (!ret && !(status & (SPU_STATUS_STOPPED_BY_STOP |
SPU_STATUS_STOPPED_BY_HALT))); SPU_STATUS_STOPPED_BY_HALT)));
ctx->ops->runcntl_stop(ctx); ctx->ops->runcntl_stop(ctx);
ret = spu_run_fini(ctx, npc, status); ret = spu_run_fini(ctx, npc, &status);
if (!ret) if (!ret)
ret = *status; ret = status;
spu_yield(ctx); spu_yield(ctx);
out: out:
*event = ctx->event_return;
up(&ctx->run_sema); up(&ctx->run_sema);
return ret; return ret;
} }
......
This diff is collapsed.
...@@ -39,6 +39,8 @@ struct spu_context_ops; ...@@ -39,6 +39,8 @@ struct spu_context_ops;
#define SPU_CONTEXT_PREEMPT 0UL #define SPU_CONTEXT_PREEMPT 0UL
struct spu_gang;
struct spu_context { struct spu_context {
struct spu *spu; /* pointer to a physical SPU */ struct spu *spu; /* pointer to a physical SPU */
struct spu_state csa; /* SPU context save area. */ struct spu_state csa; /* SPU context save area. */
...@@ -48,6 +50,7 @@ struct spu_context { ...@@ -48,6 +50,7 @@ struct spu_context {
struct address_space *cntl; /* 'control' area mappings. */ struct address_space *cntl; /* 'control' area mappings. */
struct address_space *signal1; /* 'signal1' area mappings. */ struct address_space *signal1; /* 'signal1' area mappings. */
struct address_space *signal2; /* 'signal2' area mappings. */ struct address_space *signal2; /* 'signal2' area mappings. */
u64 object_id; /* user space pointer for oprofile */
enum { SPU_STATE_RUNNABLE, SPU_STATE_SAVED } state; enum { SPU_STATE_RUNNABLE, SPU_STATE_SAVED } state;
struct rw_semaphore state_sema; struct rw_semaphore state_sema;
...@@ -66,7 +69,18 @@ struct spu_context { ...@@ -66,7 +69,18 @@ struct spu_context {
u32 tagwait; u32 tagwait;
struct spu_context_ops *ops; struct spu_context_ops *ops;
struct work_struct reap_work; struct work_struct reap_work;
u64 flags; unsigned long flags;
unsigned long event_return;
struct list_head gang_list;
struct spu_gang *gang;
};
struct spu_gang {
struct list_head list;
struct mutex mutex;
struct kref kref;
int contexts;
}; };
struct mfc_dma_command { struct mfc_dma_command {
...@@ -114,6 +128,7 @@ extern struct spu_context_ops spu_backing_ops; ...@@ -114,6 +128,7 @@ extern struct spu_context_ops spu_backing_ops;
struct spufs_inode_info { struct spufs_inode_info {
struct spu_context *i_ctx; struct spu_context *i_ctx;
struct spu_gang *i_gang;
struct inode vfs_inode; struct inode vfs_inode;
}; };
#define SPUFS_I(inode) \ #define SPUFS_I(inode) \
...@@ -124,12 +139,19 @@ extern struct tree_descr spufs_dir_contents[]; ...@@ -124,12 +139,19 @@ extern struct tree_descr spufs_dir_contents[];
/* system call implementation */ /* system call implementation */
long spufs_run_spu(struct file *file, long spufs_run_spu(struct file *file,
struct spu_context *ctx, u32 *npc, u32 *status); struct spu_context *ctx, u32 *npc, u32 *status);
long spufs_create_thread(struct nameidata *nd, long spufs_create(struct nameidata *nd,
unsigned int flags, mode_t mode); unsigned int flags, mode_t mode);
extern struct file_operations spufs_context_fops; extern struct file_operations spufs_context_fops;
/* gang management */
struct spu_gang *alloc_spu_gang(void);
struct spu_gang *get_spu_gang(struct spu_gang *gang);
int put_spu_gang(struct spu_gang *gang);
void spu_gang_remove_ctx(struct spu_gang *gang, struct spu_context *ctx);
void spu_gang_add_ctx(struct spu_gang *gang, struct spu_context *ctx);
/* context management */ /* context management */
struct spu_context * alloc_spu_context(void); struct spu_context * alloc_spu_context(struct spu_gang *gang);
void destroy_spu_context(struct kref *kref); void destroy_spu_context(struct kref *kref);
struct spu_context * get_spu_context(struct spu_context *ctx); struct spu_context * get_spu_context(struct spu_context *ctx);
int put_spu_context(struct spu_context *ctx); int put_spu_context(struct spu_context *ctx);
...@@ -183,5 +205,6 @@ void spufs_ibox_callback(struct spu *spu); ...@@ -183,5 +205,6 @@ void spufs_ibox_callback(struct spu *spu);
void spufs_wbox_callback(struct spu *spu); void spufs_wbox_callback(struct spu *spu);
void spufs_stop_callback(struct spu *spu); void spufs_stop_callback(struct spu *spu);
void spufs_mfc_callback(struct spu *spu); void spufs_mfc_callback(struct spu *spu);
void spufs_dma_callback(struct spu *spu, int type);
#endif #endif
...@@ -1779,6 +1779,15 @@ static inline void restore_mfc_cntl(struct spu_state *csa, struct spu *spu) ...@@ -1779,6 +1779,15 @@ static inline void restore_mfc_cntl(struct spu_state *csa, struct spu *spu)
*/ */
out_be64(&priv2->mfc_control_RW, csa->priv2.mfc_control_RW); out_be64(&priv2->mfc_control_RW, csa->priv2.mfc_control_RW);
eieio(); eieio();
/*
* FIXME: this is to restart a DMA that we were processing
* before the save. better remember the fault information
* in the csa instead.
*/
if ((csa->priv2.mfc_control_RW & MFC_CNTL_SUSPEND_DMA_QUEUE_MASK)) {
out_be64(&priv2->mfc_control_RW, MFC_CNTL_RESTART_DMA_COMMAND);
eieio();
}
} }
static inline void enable_user_access(struct spu_state *csa, struct spu *spu) static inline void enable_user_access(struct spu_state *csa, struct spu *spu)
......
...@@ -38,7 +38,7 @@ static long do_spu_run(struct file *filp, ...@@ -38,7 +38,7 @@ static long do_spu_run(struct file *filp,
u32 npc, status; u32 npc, status;
ret = -EFAULT; ret = -EFAULT;
if (get_user(npc, unpc) || get_user(status, ustatus)) if (get_user(npc, unpc))
goto out; goto out;
/* check if this file was created by spu_create */ /* check if this file was created by spu_create */
...@@ -49,7 +49,10 @@ static long do_spu_run(struct file *filp, ...@@ -49,7 +49,10 @@ static long do_spu_run(struct file *filp,
i = SPUFS_I(filp->f_dentry->d_inode); i = SPUFS_I(filp->f_dentry->d_inode);
ret = spufs_run_spu(filp, i->i_ctx, &npc, &status); ret = spufs_run_spu(filp, i->i_ctx, &npc, &status);
if (put_user(npc, unpc) || put_user(status, ustatus)) if (put_user(npc, unpc))
ret = -EFAULT;
if (ustatus && put_user(status, ustatus))
ret = -EFAULT; ret = -EFAULT;
out: out:
return ret; return ret;
...@@ -87,7 +90,7 @@ asmlinkage long sys_spu_create(const char __user *pathname, ...@@ -87,7 +90,7 @@ asmlinkage long sys_spu_create(const char __user *pathname,
ret = path_lookup(tmp, LOOKUP_PARENT| ret = path_lookup(tmp, LOOKUP_PARENT|
LOOKUP_OPEN|LOOKUP_CREATE, &nd); LOOKUP_OPEN|LOOKUP_CREATE, &nd);
if (!ret) { if (!ret) {
ret = spufs_create_thread(&nd, flags, mode); ret = spufs_create(&nd, flags, mode);
path_release(&nd); path_release(&nd);
} }
putname(tmp); putname(tmp);
......
...@@ -138,6 +138,7 @@ struct spu { ...@@ -138,6 +138,7 @@ struct spu {
void (* ibox_callback)(struct spu *spu); void (* ibox_callback)(struct spu *spu);
void (* stop_callback)(struct spu *spu); void (* stop_callback)(struct spu *spu);
void (* mfc_callback)(struct spu *spu); void (* mfc_callback)(struct spu *spu);
void (* dma_callback)(struct spu *spu, int type);
char irq_c0[8]; char irq_c0[8];
char irq_c1[8]; char irq_c1[8];
...@@ -147,6 +148,7 @@ struct spu { ...@@ -147,6 +148,7 @@ struct spu {
}; };
struct spu *spu_alloc(void); struct spu *spu_alloc(void);
struct spu *spu_alloc_node(int node);
void spu_free(struct spu *spu); void spu_free(struct spu *spu);
int spu_irq_class_0_bottom(struct spu *spu); int spu_irq_class_0_bottom(struct spu *spu);
int spu_irq_class_1_bottom(struct spu *spu); int spu_irq_class_1_bottom(struct spu *spu);
...@@ -168,6 +170,22 @@ extern struct spufs_calls { ...@@ -168,6 +170,22 @@ extern struct spufs_calls {
struct module *owner; struct module *owner;
} spufs_calls; } spufs_calls;
/* return status from spu_run, same as in libspe */
#define SPE_EVENT_DMA_ALIGNMENT 0x0008 /*A DMA alignment error */
#define SPE_EVENT_SPE_ERROR 0x0010 /*An illegal instruction error*/
#define SPE_EVENT_SPE_DATA_SEGMENT 0x0020 /*A DMA segmentation error */
#define SPE_EVENT_SPE_DATA_STORAGE 0x0040 /*A DMA storage error */
#define SPE_EVENT_INVALID_DMA 0x0800 /* Invalid MFC DMA */
/*
* Flags for sys_spu_create.
*/
#define SPU_CREATE_EVENTS_ENABLED 0x0001
#define SPU_CREATE_GANG 0x0002
#define SPU_CREATE_FLAG_ALL 0x0003 /* mask of all valid flags */
#ifdef CONFIG_SPU_FS_MODULE #ifdef CONFIG_SPU_FS_MODULE
int register_spu_syscalls(struct spufs_calls *calls); int register_spu_syscalls(struct spufs_calls *calls);
void unregister_spu_syscalls(struct spufs_calls *calls); void unregister_spu_syscalls(struct spufs_calls *calls);
...@@ -182,6 +200,24 @@ static inline void unregister_spu_syscalls(struct spufs_calls *calls) ...@@ -182,6 +200,24 @@ static inline void unregister_spu_syscalls(struct spufs_calls *calls)
#endif /* MODULE */ #endif /* MODULE */
/*
* Notifier blocks:
*
* oprofile can get notified when a context switch is performed
* on an spe. The notifer function that gets called is passed
* a pointer to the SPU structure as well as the object-id that
* identifies the binary running on that SPU now.
*
* For a context save, the object-id that is passed is zero,
* identifying that the kernel will run from that moment on.
*
* For a context restore, the object-id is the value written
* to object-id spufs file from user space and the notifer
* function can assume that spu->ctx is valid.
*/
int spu_switch_event_register(struct notifier_block * n);
int spu_switch_event_unregister(struct notifier_block * n);
/* /*
* This defines the Local Store, Problem Area and Privlege Area of an SPU. * This defines the Local Store, Problem Area and Privlege Area of an SPU.
*/ */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment