Commit 9f59f90b authored by Julia Lawall's avatar Julia Lawall Committed by James Morris

security/selinux/ss: correct size computation

The size argument to kcalloc should be the size of desired structure,
not the pointer to it.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@expression@
expression *x;
@@

x =
 <+...
-sizeof(x)
+sizeof(*x)
...+>// </smpl>
Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Acked-by: default avatarEric Paris <eparis@redhat.com>
Signed-off-by: default avatarJames Morris <jmorris@namei.org>
parent 6ec22f9b
...@@ -2555,7 +2555,7 @@ int security_get_classes(char ***classes, int *nclasses) ...@@ -2555,7 +2555,7 @@ int security_get_classes(char ***classes, int *nclasses)
read_lock(&policy_rwlock); read_lock(&policy_rwlock);
*nclasses = policydb.p_classes.nprim; *nclasses = policydb.p_classes.nprim;
*classes = kcalloc(*nclasses, sizeof(*classes), GFP_ATOMIC); *classes = kcalloc(*nclasses, sizeof(**classes), GFP_ATOMIC);
if (!*classes) if (!*classes)
goto out; goto out;
...@@ -2602,7 +2602,7 @@ int security_get_permissions(char *class, char ***perms, int *nperms) ...@@ -2602,7 +2602,7 @@ int security_get_permissions(char *class, char ***perms, int *nperms)
} }
*nperms = match->permissions.nprim; *nperms = match->permissions.nprim;
*perms = kcalloc(*nperms, sizeof(*perms), GFP_ATOMIC); *perms = kcalloc(*nperms, sizeof(**perms), GFP_ATOMIC);
if (!*perms) if (!*perms)
goto out; goto out;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment