Commit 9f07aa99 authored by Andrew Morton's avatar Andrew Morton Committed by James Toy

ERROR: code indent should use tabs where possible

#22: FILE: mm/memcontrol.c:1138:
+ ^I * We access a page_cgroup asynchronously without lock_page_cgroup().$

ERROR: code indent should use tabs where possible
#23: FILE: mm/memcontrol.c:1139:
+ ^I * Especially when a page_cgroup is taken from a page, pc->mem_cgroup$

ERROR: code indent should use tabs where possible
#24: FILE: mm/memcontrol.c:1140:
+ ^I * is accessed after testing USED bit. To make pc->mem_cgroup visible$

ERROR: code indent should use tabs where possible
#25: FILE: mm/memcontrol.c:1141:
+ ^I * before USED bit, we need memory barrier here.$

ERROR: code indent should use tabs where possible
#26: FILE: mm/memcontrol.c:1142:
+ ^I * See mem_cgroup_add_lru_list(), etc.$

ERROR: code indent should use tabs where possible
#27: FILE: mm/memcontrol.c:1143:
+ ^I */$

total: 6 errors, 0 warnings, 13 lines checked

./patches/memcg-add-comments-explaining-memory-barriers.patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 893d1bdf
...@@ -1135,11 +1135,11 @@ static void __mem_cgroup_commit_charge(struct mem_cgroup *mem, ...@@ -1135,11 +1135,11 @@ static void __mem_cgroup_commit_charge(struct mem_cgroup *mem,
pc->mem_cgroup = mem; pc->mem_cgroup = mem;
/* /*
* We access a page_cgroup asynchronously without lock_page_cgroup(). * We access a page_cgroup asynchronously without lock_page_cgroup().
* Especially when a page_cgroup is taken from a page, pc->mem_cgroup * Especially when a page_cgroup is taken from a page, pc->mem_cgroup
* is accessed after testing USED bit. To make pc->mem_cgroup visible * is accessed after testing USED bit. To make pc->mem_cgroup visible
* before USED bit, we need memory barrier here. * before USED bit, we need memory barrier here.
* See mem_cgroup_add_lru_list(), etc. * See mem_cgroup_add_lru_list(), etc.
*/ */
smp_wmb(); smp_wmb();
switch (ctype) { switch (ctype) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment