Commit 9be48a94 authored by Julia Lawall's avatar Julia Lawall Committed by Jesper Nilsson

It looks at least odd to apply spin_unlock to a mutex.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@def@
declarer DEFINE_MUTEX;
identifier m;
@@

DEFINE_MUTEX(m);

@@
identifier def.m;
@@

(
- spin_lock(&m)
+ mutex_lock(&m)
|
- spin_unlock(&m)
+ mutex_unlock(&m)
)
// </smpl>
Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarJesper Nilsson <jesper.nilsson@axis.com>
parent 543cf4cb
...@@ -233,7 +233,7 @@ int pcf8563_ioctl(struct inode *inode, struct file *filp, unsigned int cmd, ...@@ -233,7 +233,7 @@ int pcf8563_ioctl(struct inode *inode, struct file *filp, unsigned int cmd,
if (copy_to_user((struct rtc_time *) arg, &tm, if (copy_to_user((struct rtc_time *) arg, &tm,
sizeof tm)) { sizeof tm)) {
spin_unlock(&rtc_lock); mutex_unlock(&rtc_lock);
return -EFAULT; return -EFAULT;
} }
......
...@@ -229,7 +229,7 @@ int pcf8563_ioctl(struct inode *inode, struct file *filp, unsigned int cmd, ...@@ -229,7 +229,7 @@ int pcf8563_ioctl(struct inode *inode, struct file *filp, unsigned int cmd,
if (copy_to_user((struct rtc_time *) arg, &tm, if (copy_to_user((struct rtc_time *) arg, &tm,
sizeof tm)) { sizeof tm)) {
spin_unlock(&rtc_lock); mutex_unlock(&rtc_lock);
return -EFAULT; return -EFAULT;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment