Commit 99b28f1b authored by Phil Carmody's avatar Phil Carmody Committed by Greg Kroah-Hartman

driver core: Prevent reference to freed memory on error path

priv is drv->p. So only free drv->p after we've finished using priv.

Found using a static code analysis tool
Signed-off-by: default avatarPhil Carmody <ext-phil.2.carmody@nokia.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent e6309e75
...@@ -703,9 +703,9 @@ int bus_add_driver(struct device_driver *drv) ...@@ -703,9 +703,9 @@ int bus_add_driver(struct device_driver *drv)
return 0; return 0;
out_unregister: out_unregister:
kobject_put(&priv->kobj);
kfree(drv->p); kfree(drv->p);
drv->p = NULL; drv->p = NULL;
kobject_put(&priv->kobj);
out_put_bus: out_put_bus:
bus_put(bus); bus_put(bus);
return error; return error;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment