Commit 986a80d5 authored by Jesper Juhl's avatar Jesper Juhl Committed by Tony Luck

[PATCH] avoid signed vs unsigned comparison in efi_range_is_wc()

warning when building with gcc -W : 

 include/linux/efi.h: In function `efi_range_is_wc':
 include/linux/efi.h:320: warning: comparison between signed and unsigned

It looks to me like a significantly large 'len' passed in could cause the 
loop to never end. Isn't it safer to make 'i' an unsigned long as well? 
Like this little patch below (which of course also kills the warning) :
Signed-off-by: default avatarJesper Juhl <juhl-lkml@dif.dk>
Signed-off-by: default avatarTony Luck <tony.luck@intel.com>
parent 4845f333
...@@ -315,7 +315,7 @@ extern struct efi_memory_map memmap; ...@@ -315,7 +315,7 @@ extern struct efi_memory_map memmap;
*/ */
static inline int efi_range_is_wc(unsigned long start, unsigned long len) static inline int efi_range_is_wc(unsigned long start, unsigned long len)
{ {
int i; unsigned long i;
for (i = 0; i < len; i += (1UL << EFI_PAGE_SHIFT)) { for (i = 0; i < len; i += (1UL << EFI_PAGE_SHIFT)) {
unsigned long paddr = __pa(start + i); unsigned long paddr = __pa(start + i);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment