Commit 98365f5e authored by Antonino A. Daplas's avatar Antonino A. Daplas Committed by Linus Torvalds

[PATCH] s1d13xxxfb: Fix resource leak

struct info may not be released in the driver's error path.

Coverity Bug 672
Signed-off-by: default avatarAntonino Daplas <adaplas@pol.net>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 939205b2
...@@ -588,6 +588,7 @@ s1d13xxxfb_probe(struct platform_device *pdev) ...@@ -588,6 +588,7 @@ s1d13xxxfb_probe(struct platform_device *pdev)
goto bail; goto bail;
} }
platform_set_drvdata(pdev, info);
default_par = info->par; default_par = info->par;
default_par->regs = ioremap_nocache(pdev->resource[1].start, default_par->regs = ioremap_nocache(pdev->resource[1].start,
pdev->resource[1].end - pdev->resource[1].start +1); pdev->resource[1].end - pdev->resource[1].start +1);
...@@ -638,8 +639,6 @@ s1d13xxxfb_probe(struct platform_device *pdev) ...@@ -638,8 +639,6 @@ s1d13xxxfb_probe(struct platform_device *pdev)
goto bail; goto bail;
} }
platform_set_drvdata(pdev, info);
printk(KERN_INFO "fb%d: %s frame buffer device\n", printk(KERN_INFO "fb%d: %s frame buffer device\n",
info->node, info->fix.id); info->node, info->fix.id);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment