Commit 8bd8beab authored by Bruno Randolf's avatar Bruno Randolf Committed by John W. Linville

ath5k: use fixed antenna for tx descriptors

when using a fixed antenna we should use the antenna number in all tx
descriptors, otherwise the hardware will sometimes send the frame out on the
other antenna. it seems like the hardware does not always respect the default
antenna and diversity settings (esp.  AR5K_STA_ID1_DEFAULT_ANTENNA).

also i would like to note that antenna diversity does not always work correctly
on 5414 (at least) when only one antenna is connected: for example all frames
might be received on antenna A but still the HW tries to send on antenna B some
times, causing packet loss.

this is both verified with the antenna statistics output of the previous patch
and a spectrum analyzer.
Signed-off-by: default avatarBruno Randolf <br1@einfach.org>
Acked-by: default avatarNick Kossifidis <mickflemm@gmail.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 8e59340e
...@@ -1873,7 +1873,7 @@ ath5k_hw_set_antenna_mode(struct ath5k_hw *ah, u8 ant_mode) ...@@ -1873,7 +1873,7 @@ ath5k_hw_set_antenna_mode(struct ath5k_hw *ah, u8 ant_mode)
break; break;
case AR5K_ANTMODE_FIXED_A: case AR5K_ANTMODE_FIXED_A:
def_ant = 1; def_ant = 1;
tx_ant = 0; tx_ant = 1;
use_def_for_tx = true; use_def_for_tx = true;
update_def_on_tx = false; update_def_on_tx = false;
use_def_for_rts = true; use_def_for_rts = true;
...@@ -1882,7 +1882,7 @@ ath5k_hw_set_antenna_mode(struct ath5k_hw *ah, u8 ant_mode) ...@@ -1882,7 +1882,7 @@ ath5k_hw_set_antenna_mode(struct ath5k_hw *ah, u8 ant_mode)
break; break;
case AR5K_ANTMODE_FIXED_B: case AR5K_ANTMODE_FIXED_B:
def_ant = 2; def_ant = 2;
tx_ant = 0; tx_ant = 2;
use_def_for_tx = true; use_def_for_tx = true;
update_def_on_tx = false; update_def_on_tx = false;
use_def_for_rts = true; use_def_for_rts = true;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment