Commit 8b7f0715 authored by Andrew Morton's avatar Andrew Morton Committed by Linus Torvalds

free_irq(): fix DEBUG_SHIRQ handling

If we're going to run the handler from free_irq() then we must do it with
local irq's disabled.  Otherwise lockdep complains that the handler is taking
irq-safe spinlocks in a non-irq-safe fashion.

Cc: Ingo Molnar <mingo@elte.hu>
Cc: David Woodhouse <dwmw2@infradead.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 436bbd43
...@@ -462,7 +462,9 @@ void free_irq(unsigned int irq, void *dev_id) ...@@ -462,7 +462,9 @@ void free_irq(unsigned int irq, void *dev_id)
* We do this after actually deregistering it, to make sure that * We do this after actually deregistering it, to make sure that
* a 'real' IRQ doesn't run in parallel with our fake * a 'real' IRQ doesn't run in parallel with our fake
*/ */
local_irq_save(flags);
handler(irq, dev_id); handler(irq, dev_id);
local_irq_restore(flags);
} }
#endif #endif
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment