Commit 72240307 authored by Jean Delvare's avatar Jean Delvare Committed by Mark M. Hoffman

hwmon: (gl518sm) Fix the reported fan speed

The fan speeds reported by the gl518sm driver are twice as much as they
should. It's currently reporting the number of pulses per minute, not
rotations per minute, while typical fans emit two pulses per rotation.
This explains why all reports with this driver had very high speed
values (between 9000 to 12000 RPM). Odd that nobody ever actually
complained about this bug.
Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
Signed-off-by: default avatarMark M. Hoffman <mhoffman@lightlink.com>
parent 21df67b1
...@@ -96,10 +96,10 @@ static inline u8 FAN_TO_REG(long rpm, int div) ...@@ -96,10 +96,10 @@ static inline u8 FAN_TO_REG(long rpm, int div)
long rpmdiv; long rpmdiv;
if (rpm == 0) if (rpm == 0)
return 0; return 0;
rpmdiv = SENSORS_LIMIT(rpm, 1, 1920000) * div; rpmdiv = SENSORS_LIMIT(rpm, 1, 960000) * div;
return SENSORS_LIMIT((960000 + rpmdiv / 2) / rpmdiv, 1, 255); return SENSORS_LIMIT((480000 + rpmdiv / 2) / rpmdiv, 1, 255);
} }
#define FAN_FROM_REG(val,div) ((val)==0 ? 0 : (960000/((val)*(div)))) #define FAN_FROM_REG(val,div) ((val)==0 ? 0 : (480000/((val)*(div))))
#define IN_TO_REG(val) (SENSORS_LIMIT((((val)+9)/19),0,255)) #define IN_TO_REG(val) (SENSORS_LIMIT((((val)+9)/19),0,255))
#define IN_FROM_REG(val) ((val)*19) #define IN_FROM_REG(val) ((val)*19)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment