Commit 720a650f authored by Herbert Xu's avatar Herbert Xu Committed by David S. Miller

[CRYPTO] cryptomgr: Fix parsing of recursive algorithms

As Joy Latten points out, inner algorithm parameters will miss the closing
bracket which will also cause the outer algorithm to terminate prematurely.

This patch fixes that also kills the WARN_ON if the number of parameters
exceed the maximum as that is a user error.
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent f19f5111
...@@ -129,6 +129,7 @@ static int cryptomgr_schedule_probe(struct crypto_larval *larval) ...@@ -129,6 +129,7 @@ static int cryptomgr_schedule_probe(struct crypto_larval *larval)
} }
notnum = 1; notnum = 1;
p++;
} }
len = p - name; len = p - name;
...@@ -151,7 +152,7 @@ static int cryptomgr_schedule_probe(struct crypto_larval *larval) ...@@ -151,7 +152,7 @@ static int cryptomgr_schedule_probe(struct crypto_larval *larval)
param->tb[i + 1] = &param->attrs[i].attr; param->tb[i + 1] = &param->attrs[i].attr;
i++; i++;
if (WARN_ON(i >= CRYPTO_MAX_ATTRS)) if (i >= CRYPTO_MAX_ATTRS)
goto err_free_param; goto err_free_param;
if (*p == ')') if (*p == ')')
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment