Commit 7132799b authored by Valentine Barshak's avatar Valentine Barshak Committed by Olof Johansson

[POWERPC] kexec: MPIC ack interrupts at mpic_teardown_this_cpu()

We really need to ack interrupts at mpic_teardown, since
not all platforms reset mpic at kernel start-up. For example,
kexec'ed kernel hangs on P.A. Semi if mpic_eoi() isn't called.
Signed-off-by: default avatarValentine Barshak <vbarshak@ru.mvista.com>
Signed-off-by: default avatarOlof Johansson <olof@lixom.net>
parent f724bf77
...@@ -1410,11 +1410,6 @@ void mpic_cpu_set_priority(int prio) ...@@ -1410,11 +1410,6 @@ void mpic_cpu_set_priority(int prio)
mpic_cpu_write(MPIC_INFO(CPU_CURRENT_TASK_PRI), prio); mpic_cpu_write(MPIC_INFO(CPU_CURRENT_TASK_PRI), prio);
} }
/*
* XXX: someone who knows mpic should check this.
* do we need to eoi the ipi including for kexec cpu here (see xics comments)?
* or can we reset the mpic in the new kernel?
*/
void mpic_teardown_this_cpu(int secondary) void mpic_teardown_this_cpu(int secondary)
{ {
struct mpic *mpic = mpic_primary; struct mpic *mpic = mpic_primary;
...@@ -1434,6 +1429,10 @@ void mpic_teardown_this_cpu(int secondary) ...@@ -1434,6 +1429,10 @@ void mpic_teardown_this_cpu(int secondary)
/* Set current processor priority to max */ /* Set current processor priority to max */
mpic_cpu_write(MPIC_INFO(CPU_CURRENT_TASK_PRI), 0xf); mpic_cpu_write(MPIC_INFO(CPU_CURRENT_TASK_PRI), 0xf);
/* We need to EOI the IPI since not all platforms reset the MPIC
* on boot and new interrupts wouldn't get delivered otherwise.
*/
mpic_eoi(mpic);
spin_unlock_irqrestore(&mpic_lock, flags); spin_unlock_irqrestore(&mpic_lock, flags);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment