Commit 6ca15ba2 authored by Andrew Morton's avatar Andrew Morton Committed by james toy

ERROR: that open brace { should be on the previous line

#184: FILE: lib/decompress_unlzo.c:48:
+static const unsigned char lzop_magic[] =
+	{ 0x89, 0x4c, 0x5a, 0x4f, 0x00, 0x0d, 0x0a, 0x1a, 0x0a };

WARNING: line over 80 characters
#254: FILE: lib/decompress_unlzo.c:118:
+		error("Both input pointer and fill function provided, don't know what to do");

WARNING: line over 80 characters
#259: FILE: lib/decompress_unlzo.c:123:
+		error("NULL input pointer and missing position pointer or fill function");

WARNING: line over 80 characters
#313: FILE: lib/decompress_unlzo.c:177:
+		r = lzo1x_decompress_safe((u8 *) in_buf, src_len, out_buf, &tmp);

total: 1 errors, 3 warnings, 291 lines checked

./patches/lib-add-support-for-lzo-compressed-kernels.patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Albin Tonnerre <albin.tonnerre@free-electrons.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Russell King <rmk@arm.linux.org.uk>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Wu Zhangjin <wuzhangjin@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent efca0bcd
...@@ -44,8 +44,8 @@ ...@@ -44,8 +44,8 @@
#include <linux/compiler.h> #include <linux/compiler.h>
#include <asm/unaligned.h> #include <asm/unaligned.h>
static const unsigned char lzop_magic[] = static const unsigned char lzop_magic[] = {
{ 0x89, 0x4c, 0x5a, 0x4f, 0x00, 0x0d, 0x0a, 0x1a, 0x0a }; 0x89, 0x4c, 0x5a, 0x4f, 0x00, 0x0d, 0x0a, 0x1a, 0x0a };
#define LZO_BLOCK_SIZE (256*1024l) #define LZO_BLOCK_SIZE (256*1024l)
#define HEADER_HAS_FILTER 0x00000800L #define HEADER_HAS_FILTER 0x00000800L
...@@ -174,7 +174,8 @@ STATIC inline int INIT unlzo(u8 *input, int in_len, ...@@ -174,7 +174,8 @@ STATIC inline int INIT unlzo(u8 *input, int in_len,
/* decompress */ /* decompress */
tmp = dst_len; tmp = dst_len;
r = lzo1x_decompress_safe((u8 *) in_buf, src_len, out_buf, &tmp); r = lzo1x_decompress_safe((u8 *) in_buf, src_len,
out_buf, &tmp);
if (r != LZO_E_OK || dst_len != tmp) { if (r != LZO_E_OK || dst_len != tmp) {
error("Compressed data violation"); error("Compressed data violation");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment