Commit 6c0f8bc7 authored by Stoyan Gaydarov's avatar Stoyan Gaydarov Committed by David S. Miller

sbus: changed ioctls to unlocked

Signed-off-by: default avatarStoyan Gaydarov <stoyboyker@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c7cb1521
...@@ -383,18 +383,22 @@ static int jsf_ioctl_program(void __user *arg) ...@@ -383,18 +383,22 @@ static int jsf_ioctl_program(void __user *arg)
return 0; return 0;
} }
static int jsf_ioctl(struct inode *inode, struct file *f, unsigned int cmd, static long jsf_ioctl(struct file *f, unsigned int cmd, unsigned long arg)
unsigned long arg)
{ {
lock_kernel();
int error = -ENOTTY; int error = -ENOTTY;
void __user *argp = (void __user *)arg; void __user *argp = (void __user *)arg;
if (!capable(CAP_SYS_ADMIN)) if (!capable(CAP_SYS_ADMIN)) {
unlock_kernel();
return -EPERM; return -EPERM;
}
switch (cmd) { switch (cmd) {
case JSFLASH_IDENT: case JSFLASH_IDENT:
if (copy_to_user(argp, &jsf0.id, JSFIDSZ)) if (copy_to_user(argp, &jsf0.id, JSFIDSZ)) {
unlock_kernel();
return -EFAULT; return -EFAULT;
}
break; break;
case JSFLASH_ERASE: case JSFLASH_ERASE:
error = jsf_ioctl_erase(arg); error = jsf_ioctl_erase(arg);
...@@ -404,6 +408,7 @@ static int jsf_ioctl(struct inode *inode, struct file *f, unsigned int cmd, ...@@ -404,6 +408,7 @@ static int jsf_ioctl(struct inode *inode, struct file *f, unsigned int cmd,
break; break;
} }
unlock_kernel();
return error; return error;
} }
...@@ -439,7 +444,7 @@ static const struct file_operations jsf_fops = { ...@@ -439,7 +444,7 @@ static const struct file_operations jsf_fops = {
.llseek = jsf_lseek, .llseek = jsf_lseek,
.read = jsf_read, .read = jsf_read,
.write = jsf_write, .write = jsf_write,
.ioctl = jsf_ioctl, .unlocked_ioctl = jsf_ioctl,
.mmap = jsf_mmap, .mmap = jsf_mmap,
.open = jsf_open, .open = jsf_open,
.release = jsf_release, .release = jsf_release,
......
...@@ -197,9 +197,8 @@ static struct uctrl_driver { ...@@ -197,9 +197,8 @@ static struct uctrl_driver {
static void uctrl_get_event_status(struct uctrl_driver *); static void uctrl_get_event_status(struct uctrl_driver *);
static void uctrl_get_external_status(struct uctrl_driver *); static void uctrl_get_external_status(struct uctrl_driver *);
static int static long
uctrl_ioctl(struct inode *inode, struct file *file, uctrl_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
unsigned int cmd, unsigned long arg)
{ {
switch (cmd) { switch (cmd) {
default: default:
...@@ -226,7 +225,7 @@ static irqreturn_t uctrl_interrupt(int irq, void *dev_id) ...@@ -226,7 +225,7 @@ static irqreturn_t uctrl_interrupt(int irq, void *dev_id)
static const struct file_operations uctrl_fops = { static const struct file_operations uctrl_fops = {
.owner = THIS_MODULE, .owner = THIS_MODULE,
.llseek = no_llseek, .llseek = no_llseek,
.ioctl = uctrl_ioctl, .unlocked_ioctl = uctrl_ioctl,
.open = uctrl_open, .open = uctrl_open,
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment