Commit 63c9a8b3 authored by Márton Németh's avatar Márton Németh Committed by Dominik Brodowski

pcmcia: make Open Firmware device id constant

The match_table field of the struct of_device_id is constant in <linux/of_platform.h>
so it is worth to make the initialization data also constant.

The semantic match that finds this kind of pattern is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
disable decl_init,const_decl_init;
identifier I1, I2, x;
@@
	struct I1 {
	  ...
	  const struct I2 *x;
	  ...
	};
@s@
identifier r.I1, y;
identifier r.x, E;
@@
	struct I1 y = {
	  .x = E,
	};
@c@
identifier r.I2;
identifier s.E;
@@
	const struct I2 E[] = ... ;
@depends on !c@
identifier r.I2;
identifier s.E;
@@
+	const
	struct I2 E[] = ...;
// </smpl>
Signed-off-by: default avatarMárton Németh <nm127@freemail.hu>
Cc: Julia Lawall <julia@diku.dk>
Cc: cocci@diku.dk
Acked-by: default avatarWolfram Sang <w.sang@pengutronix.de>
Signed-off-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
parent c6be9c5a
...@@ -347,7 +347,7 @@ static int __devexit electra_cf_remove(struct of_device *ofdev) ...@@ -347,7 +347,7 @@ static int __devexit electra_cf_remove(struct of_device *ofdev)
return 0; return 0;
} }
static struct of_device_id electra_cf_match[] = { static const struct of_device_id electra_cf_match[] = {
{ {
.compatible = "electra-cf", .compatible = "electra-cf",
}, },
......
...@@ -1303,7 +1303,7 @@ static int m8xx_resume(struct platform_device *pdev) ...@@ -1303,7 +1303,7 @@ static int m8xx_resume(struct platform_device *pdev)
#define m8xx_resume NULL #define m8xx_resume NULL
#endif #endif
static struct of_device_id m8xx_pcmcia_match[] = { static const struct of_device_id m8xx_pcmcia_match[] = {
{ {
.type = "pcmcia", .type = "pcmcia",
.compatible = "fsl,pq-pcmcia", .compatible = "fsl,pq-pcmcia",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment