Commit 5f707eb4 authored by Trond Myklebust's avatar Trond Myklebust

SUNRPC: Fix potential race in put_rpccred()

We have to be careful when we try to unhash the credential in
put_rpccred(), because we're not holding the credcache lock, so the call to
rpcauth_unhash_cred() may fail if someone else has looked the cred up, and
obtained a reference to it.
Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
parent eac0d18d
...@@ -455,7 +455,7 @@ need_lock: ...@@ -455,7 +455,7 @@ need_lock:
} }
if (test_bit(RPCAUTH_CRED_UPTODATE, &cred->cr_flags) == 0) if (test_bit(RPCAUTH_CRED_UPTODATE, &cred->cr_flags) == 0)
rpcauth_unhash_cred(cred); rpcauth_unhash_cred(cred);
else if (test_bit(RPCAUTH_CRED_HASHED, &cred->cr_flags) != 0) { if (test_bit(RPCAUTH_CRED_HASHED, &cred->cr_flags) != 0) {
cred->cr_expire = jiffies; cred->cr_expire = jiffies;
list_add_tail(&cred->cr_lru, &cred_unused); list_add_tail(&cred->cr_lru, &cred_unused);
number_cred_unused++; number_cred_unused++;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment