Commit 5e96093d authored by Paul Walmsley's avatar Paul Walmsley Committed by Tony Lindgren

OMAP2/3 clock: drop recalc function pointers from fixed rate clocks

Now that rate recalculation and rate propagation are two separate
operations, drop recalc function pointers from all fixed rate clocks.
Their rates are fixed, so there's no need to recalculate.
Signed-off-by: default avatarPaul Walmsley <paul@pwsan.com>
Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
parent b66c1baa
...@@ -627,7 +627,6 @@ static struct clk func_32k_ck = { ...@@ -627,7 +627,6 @@ static struct clk func_32k_ck = {
.flags = CLOCK_IN_OMAP242X | CLOCK_IN_OMAP243X | .flags = CLOCK_IN_OMAP242X | CLOCK_IN_OMAP243X |
RATE_FIXED | ALWAYS_ENABLED | RATE_PROPAGATES, RATE_FIXED | ALWAYS_ENABLED | RATE_PROPAGATES,
.clkdm = { .name = "prm_clkdm" }, .clkdm = { .name = "prm_clkdm" },
.recalc = &propagate_rate,
}; };
/* Typical 12/13MHz in standalone mode, will be 26Mhz in chassis mode */ /* Typical 12/13MHz in standalone mode, will be 26Mhz in chassis mode */
...@@ -657,7 +656,6 @@ static struct clk alt_ck = { /* Typical 54M or 48M, may not exist */ ...@@ -657,7 +656,6 @@ static struct clk alt_ck = { /* Typical 54M or 48M, may not exist */
.flags = CLOCK_IN_OMAP242X | CLOCK_IN_OMAP243X | .flags = CLOCK_IN_OMAP242X | CLOCK_IN_OMAP243X |
RATE_FIXED | ALWAYS_ENABLED | RATE_PROPAGATES, RATE_FIXED | ALWAYS_ENABLED | RATE_PROPAGATES,
.clkdm = { .name = "prm_clkdm" }, .clkdm = { .name = "prm_clkdm" },
.recalc = &propagate_rate,
}; };
/* /*
...@@ -709,7 +707,6 @@ static struct clk apll96_ck = { ...@@ -709,7 +707,6 @@ static struct clk apll96_ck = {
.enable_bit = OMAP24XX_EN_96M_PLL_SHIFT, .enable_bit = OMAP24XX_EN_96M_PLL_SHIFT,
.enable = &omap2_clk_fixed_enable, .enable = &omap2_clk_fixed_enable,
.disable = &omap2_clk_fixed_disable, .disable = &omap2_clk_fixed_disable,
.recalc = &propagate_rate,
}; };
static struct clk apll54_ck = { static struct clk apll54_ck = {
...@@ -724,7 +721,6 @@ static struct clk apll54_ck = { ...@@ -724,7 +721,6 @@ static struct clk apll54_ck = {
.enable_bit = OMAP24XX_EN_54M_PLL_SHIFT, .enable_bit = OMAP24XX_EN_54M_PLL_SHIFT,
.enable = &omap2_clk_fixed_enable, .enable = &omap2_clk_fixed_enable,
.disable = &omap2_clk_fixed_disable, .disable = &omap2_clk_fixed_disable,
.recalc = &propagate_rate,
}; };
/* /*
......
...@@ -67,7 +67,6 @@ static struct clk omap_32k_fck = { ...@@ -67,7 +67,6 @@ static struct clk omap_32k_fck = {
.flags = CLOCK_IN_OMAP343X | RATE_FIXED | RATE_PROPAGATES | .flags = CLOCK_IN_OMAP343X | RATE_FIXED | RATE_PROPAGATES |
ALWAYS_ENABLED, ALWAYS_ENABLED,
.clkdm = { .name = "prm_clkdm" }, .clkdm = { .name = "prm_clkdm" },
.recalc = &propagate_rate,
}; };
static struct clk secure_32k_fck = { static struct clk secure_32k_fck = {
...@@ -76,7 +75,6 @@ static struct clk secure_32k_fck = { ...@@ -76,7 +75,6 @@ static struct clk secure_32k_fck = {
.flags = CLOCK_IN_OMAP343X | RATE_FIXED | RATE_PROPAGATES | .flags = CLOCK_IN_OMAP343X | RATE_FIXED | RATE_PROPAGATES |
ALWAYS_ENABLED, ALWAYS_ENABLED,
.clkdm = { .name = "prm_clkdm" }, .clkdm = { .name = "prm_clkdm" },
.recalc = &propagate_rate,
}; };
/* Virtual source clocks for osc_sys_ck */ /* Virtual source clocks for osc_sys_ck */
...@@ -86,7 +84,6 @@ static struct clk virt_12m_ck = { ...@@ -86,7 +84,6 @@ static struct clk virt_12m_ck = {
.flags = CLOCK_IN_OMAP343X | RATE_FIXED | RATE_PROPAGATES | .flags = CLOCK_IN_OMAP343X | RATE_FIXED | RATE_PROPAGATES |
ALWAYS_ENABLED, ALWAYS_ENABLED,
.clkdm = { .name = "prm_clkdm" }, .clkdm = { .name = "prm_clkdm" },
.recalc = &propagate_rate,
}; };
static struct clk virt_13m_ck = { static struct clk virt_13m_ck = {
...@@ -95,7 +92,6 @@ static struct clk virt_13m_ck = { ...@@ -95,7 +92,6 @@ static struct clk virt_13m_ck = {
.flags = CLOCK_IN_OMAP343X | RATE_FIXED | RATE_PROPAGATES | .flags = CLOCK_IN_OMAP343X | RATE_FIXED | RATE_PROPAGATES |
ALWAYS_ENABLED, ALWAYS_ENABLED,
.clkdm = { .name = "prm_clkdm" }, .clkdm = { .name = "prm_clkdm" },
.recalc = &propagate_rate,
}; };
static struct clk virt_16_8m_ck = { static struct clk virt_16_8m_ck = {
...@@ -104,7 +100,6 @@ static struct clk virt_16_8m_ck = { ...@@ -104,7 +100,6 @@ static struct clk virt_16_8m_ck = {
.flags = CLOCK_IN_OMAP3430ES2 | RATE_FIXED | RATE_PROPAGATES | .flags = CLOCK_IN_OMAP3430ES2 | RATE_FIXED | RATE_PROPAGATES |
ALWAYS_ENABLED, ALWAYS_ENABLED,
.clkdm = { .name = "prm_clkdm" }, .clkdm = { .name = "prm_clkdm" },
.recalc = &propagate_rate,
}; };
static struct clk virt_19_2m_ck = { static struct clk virt_19_2m_ck = {
...@@ -113,7 +108,6 @@ static struct clk virt_19_2m_ck = { ...@@ -113,7 +108,6 @@ static struct clk virt_19_2m_ck = {
.flags = CLOCK_IN_OMAP343X | RATE_FIXED | RATE_PROPAGATES | .flags = CLOCK_IN_OMAP343X | RATE_FIXED | RATE_PROPAGATES |
ALWAYS_ENABLED, ALWAYS_ENABLED,
.clkdm = { .name = "prm_clkdm" }, .clkdm = { .name = "prm_clkdm" },
.recalc = &propagate_rate,
}; };
static struct clk virt_26m_ck = { static struct clk virt_26m_ck = {
...@@ -122,7 +116,6 @@ static struct clk virt_26m_ck = { ...@@ -122,7 +116,6 @@ static struct clk virt_26m_ck = {
.flags = CLOCK_IN_OMAP343X | RATE_FIXED | RATE_PROPAGATES | .flags = CLOCK_IN_OMAP343X | RATE_FIXED | RATE_PROPAGATES |
ALWAYS_ENABLED, ALWAYS_ENABLED,
.clkdm = { .name = "prm_clkdm" }, .clkdm = { .name = "prm_clkdm" },
.recalc = &propagate_rate,
}; };
static struct clk virt_38_4m_ck = { static struct clk virt_38_4m_ck = {
...@@ -131,7 +124,6 @@ static struct clk virt_38_4m_ck = { ...@@ -131,7 +124,6 @@ static struct clk virt_38_4m_ck = {
.flags = CLOCK_IN_OMAP343X | RATE_FIXED | RATE_PROPAGATES | .flags = CLOCK_IN_OMAP343X | RATE_FIXED | RATE_PROPAGATES |
ALWAYS_ENABLED, ALWAYS_ENABLED,
.clkdm = { .name = "prm_clkdm" }, .clkdm = { .name = "prm_clkdm" },
.recalc = &propagate_rate,
}; };
static const struct clksel_rate osc_sys_12m_rates[] = { static const struct clksel_rate osc_sys_12m_rates[] = {
...@@ -220,7 +212,6 @@ static struct clk sys_altclk = { ...@@ -220,7 +212,6 @@ static struct clk sys_altclk = {
.name = "sys_altclk", .name = "sys_altclk",
.flags = CLOCK_IN_OMAP343X | RATE_PROPAGATES | ALWAYS_ENABLED, .flags = CLOCK_IN_OMAP343X | RATE_PROPAGATES | ALWAYS_ENABLED,
.clkdm = { .name = "cm_clkdm" }, .clkdm = { .name = "cm_clkdm" },
.recalc = &propagate_rate,
}; };
/* /*
...@@ -232,7 +223,6 @@ static struct clk mcbsp_clks = { ...@@ -232,7 +223,6 @@ static struct clk mcbsp_clks = {
.name = "mcbsp_clks", .name = "mcbsp_clks",
.flags = CLOCK_IN_OMAP343X | RATE_PROPAGATES | ALWAYS_ENABLED, .flags = CLOCK_IN_OMAP343X | RATE_PROPAGATES | ALWAYS_ENABLED,
.clkdm = { .name = "prm_clkdm" }, .clkdm = { .name = "prm_clkdm" },
.recalc = &propagate_rate,
}; };
/* PRM EXTERNAL CLOCK OUTPUT */ /* PRM EXTERNAL CLOCK OUTPUT */
......
...@@ -187,7 +187,8 @@ int clk_set_rate(struct clk *clk, unsigned long rate) ...@@ -187,7 +187,8 @@ int clk_set_rate(struct clk *clk, unsigned long rate)
if (arch_clock->clk_set_rate) { if (arch_clock->clk_set_rate) {
ret = arch_clock->clk_set_rate(clk, rate); ret = arch_clock->clk_set_rate(clk, rate);
if (ret == 0) { if (ret == 0) {
(*clk->recalc)(clk); if (clk->recalc)
(*clk->recalc)(clk);
if (clk->flags & RATE_PROPAGATES) if (clk->flags & RATE_PROPAGATES)
propagate_rate(clk); propagate_rate(clk);
} }
...@@ -212,7 +213,8 @@ int clk_set_parent(struct clk *clk, struct clk *parent) ...@@ -212,7 +213,8 @@ int clk_set_parent(struct clk *clk, struct clk *parent)
if (arch_clock->clk_set_parent) { if (arch_clock->clk_set_parent) {
ret = arch_clock->clk_set_parent(clk, parent); ret = arch_clock->clk_set_parent(clk, parent);
if (ret == 0) { if (ret == 0) {
(*clk->recalc)(clk); if (clk->recalc)
(*clk->recalc)(clk);
if (clk->flags & RATE_PROPAGATES) if (clk->flags & RATE_PROPAGATES)
propagate_rate(clk); propagate_rate(clk);
} }
...@@ -285,11 +287,10 @@ void propagate_rate(struct clk * tclk) ...@@ -285,11 +287,10 @@ void propagate_rate(struct clk * tclk)
list_for_each_entry(clkp, &clocks, node) { list_for_each_entry(clkp, &clocks, node) {
if (likely(clkp->parent != tclk)) if (likely(clkp->parent != tclk))
continue; continue;
if (likely((u32)clkp->recalc)) { if (clkp->recalc)
clkp->recalc(clkp); clkp->recalc(clkp);
if (clkp->flags & RATE_PROPAGATES) if (clkp->flags & RATE_PROPAGATES)
propagate_rate(clkp); propagate_rate(clkp);
}
} }
} }
...@@ -305,8 +306,9 @@ void recalculate_root_clocks(void) ...@@ -305,8 +306,9 @@ void recalculate_root_clocks(void)
struct clk *clkp; struct clk *clkp;
list_for_each_entry(clkp, &clocks, node) { list_for_each_entry(clkp, &clocks, node) {
if (unlikely(!clkp->parent) && likely((u32)clkp->recalc)) { if (unlikely(!clkp->parent)) {
clkp->recalc(clkp); if (clkp->recalc)
clkp->recalc(clkp);
if (clkp->flags & RATE_PROPAGATES) if (clkp->flags & RATE_PROPAGATES)
propagate_rate(clkp); propagate_rate(clkp);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment