Commit 5872144f authored by Li Zefan's avatar Li Zefan Committed by Steven Rostedt

tracing/filters: fix off-by-one bug

We should leave the last slot for the ending '\0'.

[ Impact: fix possible crash when the length of an operand is 128 ]
Signed-off-by: default avatarLi Zefan <lizf@cn.fujitsu.com>
LKML-Reference: <4A0CDC8C.30602@cn.fujitsu.com>
Signed-off-by: default avatarSteven Rostedt <rostedt@goodmis.org>
parent 8cd995b6
...@@ -736,7 +736,7 @@ static inline void clear_operand_string(struct filter_parse_state *ps) ...@@ -736,7 +736,7 @@ static inline void clear_operand_string(struct filter_parse_state *ps)
static inline int append_operand_char(struct filter_parse_state *ps, char c) static inline int append_operand_char(struct filter_parse_state *ps, char c)
{ {
if (ps->operand.tail == MAX_FILTER_STR_VAL) if (ps->operand.tail == MAX_FILTER_STR_VAL - 1)
return -EINVAL; return -EINVAL;
ps->operand.string[ps->operand.tail++] = c; ps->operand.string[ps->operand.tail++] = c;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment