Commit 570106df authored by Tejun Heo's avatar Tejun Heo Committed by Jeff Garzik

libata-sff: fix ata_sff_post_internal_cmd()

ata_sff_post_internal_cmd() needs to grab port lock before calling
ata_bmdma_stop() and also need to clear hsm_task_state.  Fix it.
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
parent f667fdbb
...@@ -2153,8 +2153,17 @@ void ata_sff_error_handler(struct ata_port *ap) ...@@ -2153,8 +2153,17 @@ void ata_sff_error_handler(struct ata_port *ap)
*/ */
void ata_sff_post_internal_cmd(struct ata_queued_cmd *qc) void ata_sff_post_internal_cmd(struct ata_queued_cmd *qc)
{ {
if (qc->ap->ioaddr.bmdma_addr) struct ata_port *ap = qc->ap;
unsigned long flags;
spin_lock_irqsave(ap->lock, flags);
ap->hsm_task_state = HSM_ST_IDLE;
if (ap->ioaddr.bmdma_addr)
ata_bmdma_stop(qc); ata_bmdma_stop(qc);
spin_unlock_irqrestore(ap->lock, flags);
} }
/** /**
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment