Commit 55da7789 authored by Alan Cox's avatar Alan Cox Committed by Linus Torvalds

synclink series: switch to int put_char method

Signed-off-by: default avatarAlan Cox <alan@redhat.com>
Cc: Paul Fulghum <paulkf@microgate.com>
Cc: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 6ae04576
...@@ -2026,10 +2026,11 @@ static void mgsl_change_params(struct mgsl_struct *info) ...@@ -2026,10 +2026,11 @@ static void mgsl_change_params(struct mgsl_struct *info)
* *
* Return Value: None * Return Value: None
*/ */
static void mgsl_put_char(struct tty_struct *tty, unsigned char ch) static int mgsl_put_char(struct tty_struct *tty, unsigned char ch)
{ {
struct mgsl_struct *info = (struct mgsl_struct *)tty->driver_data; struct mgsl_struct *info = (struct mgsl_struct *)tty->driver_data;
unsigned long flags; unsigned long flags;
int ret;
if ( debug_level >= DEBUG_LEVEL_INFO ) { if ( debug_level >= DEBUG_LEVEL_INFO ) {
printk( "%s(%d):mgsl_put_char(%d) on %s\n", printk( "%s(%d):mgsl_put_char(%d) on %s\n",
...@@ -2037,23 +2038,23 @@ static void mgsl_put_char(struct tty_struct *tty, unsigned char ch) ...@@ -2037,23 +2038,23 @@ static void mgsl_put_char(struct tty_struct *tty, unsigned char ch)
} }
if (mgsl_paranoia_check(info, tty->name, "mgsl_put_char")) if (mgsl_paranoia_check(info, tty->name, "mgsl_put_char"))
return; return 0;
if (!tty || !info->xmit_buf) if (!tty || !info->xmit_buf)
return; return 0;
spin_lock_irqsave(&info->irq_spinlock,flags); spin_lock_irqsave(&info->irq_spinlock,flags);
if ( (info->params.mode == MGSL_MODE_ASYNC ) || !info->tx_active ) { if ( (info->params.mode == MGSL_MODE_ASYNC ) || !info->tx_active ) {
if (info->xmit_cnt < SERIAL_XMIT_SIZE - 1) { if (info->xmit_cnt < SERIAL_XMIT_SIZE - 1) {
info->xmit_buf[info->xmit_head++] = ch; info->xmit_buf[info->xmit_head++] = ch;
info->xmit_head &= SERIAL_XMIT_SIZE-1; info->xmit_head &= SERIAL_XMIT_SIZE-1;
info->xmit_cnt++; info->xmit_cnt++;
ret = 1;
} }
} }
spin_unlock_irqrestore(&info->irq_spinlock,flags); spin_unlock_irqrestore(&info->irq_spinlock,flags);
return ret;
} /* end of mgsl_put_char() */ } /* end of mgsl_put_char() */
......
...@@ -151,7 +151,7 @@ static void hangup(struct tty_struct *tty); ...@@ -151,7 +151,7 @@ static void hangup(struct tty_struct *tty);
static void set_termios(struct tty_struct *tty, struct ktermios *old_termios); static void set_termios(struct tty_struct *tty, struct ktermios *old_termios);
static int write(struct tty_struct *tty, const unsigned char *buf, int count); static int write(struct tty_struct *tty, const unsigned char *buf, int count);
static void put_char(struct tty_struct *tty, unsigned char ch); static int put_char(struct tty_struct *tty, unsigned char ch);
static void send_xchar(struct tty_struct *tty, char ch); static void send_xchar(struct tty_struct *tty, char ch);
static void wait_until_sent(struct tty_struct *tty, int timeout); static void wait_until_sent(struct tty_struct *tty, int timeout);
static int write_room(struct tty_struct *tty); static int write_room(struct tty_struct *tty);
...@@ -912,20 +912,24 @@ cleanup: ...@@ -912,20 +912,24 @@ cleanup:
return ret; return ret;
} }
static void put_char(struct tty_struct *tty, unsigned char ch) static int put_char(struct tty_struct *tty, unsigned char ch)
{ {
struct slgt_info *info = tty->driver_data; struct slgt_info *info = tty->driver_data;
unsigned long flags; unsigned long flags;
int ret;
if (sanity_check(info, tty->name, "put_char")) if (sanity_check(info, tty->name, "put_char"))
return; return 0;
DBGINFO(("%s put_char(%d)\n", info->device_name, ch)); DBGINFO(("%s put_char(%d)\n", info->device_name, ch));
if (!info->tx_buf) if (!info->tx_buf)
return; return 0;
spin_lock_irqsave(&info->lock,flags); spin_lock_irqsave(&info->lock,flags);
if (!info->tx_active && (info->tx_count < info->max_frame_size)) if (!info->tx_active && (info->tx_count < info->max_frame_size)) {
info->tx_buf[info->tx_count++] = ch; info->tx_buf[info->tx_count++] = ch;
ret = 1;
}
spin_unlock_irqrestore(&info->lock,flags); spin_unlock_irqrestore(&info->lock,flags);
return ret;
} }
static void send_xchar(struct tty_struct *tty, char ch) static void send_xchar(struct tty_struct *tty, char ch)
......
...@@ -519,7 +519,7 @@ static void hangup(struct tty_struct *tty); ...@@ -519,7 +519,7 @@ static void hangup(struct tty_struct *tty);
static void set_termios(struct tty_struct *tty, struct ktermios *old_termios); static void set_termios(struct tty_struct *tty, struct ktermios *old_termios);
static int write(struct tty_struct *tty, const unsigned char *buf, int count); static int write(struct tty_struct *tty, const unsigned char *buf, int count);
static void put_char(struct tty_struct *tty, unsigned char ch); static int put_char(struct tty_struct *tty, unsigned char ch);
static void send_xchar(struct tty_struct *tty, char ch); static void send_xchar(struct tty_struct *tty, char ch);
static void wait_until_sent(struct tty_struct *tty, int timeout); static void wait_until_sent(struct tty_struct *tty, int timeout);
static int write_room(struct tty_struct *tty); static int write_room(struct tty_struct *tty);
...@@ -1045,10 +1045,11 @@ cleanup: ...@@ -1045,10 +1045,11 @@ cleanup:
/* Add a character to the transmit buffer. /* Add a character to the transmit buffer.
*/ */
static void put_char(struct tty_struct *tty, unsigned char ch) static int put_char(struct tty_struct *tty, unsigned char ch)
{ {
SLMP_INFO *info = (SLMP_INFO *)tty->driver_data; SLMP_INFO *info = (SLMP_INFO *)tty->driver_data;
unsigned long flags; unsigned long flags;
int ret = 0;
if ( debug_level >= DEBUG_LEVEL_INFO ) { if ( debug_level >= DEBUG_LEVEL_INFO ) {
printk( "%s(%d):%s put_char(%d)\n", printk( "%s(%d):%s put_char(%d)\n",
...@@ -1056,10 +1057,10 @@ static void put_char(struct tty_struct *tty, unsigned char ch) ...@@ -1056,10 +1057,10 @@ static void put_char(struct tty_struct *tty, unsigned char ch)
} }
if (sanity_check(info, tty->name, "put_char")) if (sanity_check(info, tty->name, "put_char"))
return; return 0;
if (!info->tx_buf) if (!info->tx_buf)
return; return 0;
spin_lock_irqsave(&info->lock,flags); spin_lock_irqsave(&info->lock,flags);
...@@ -1071,10 +1072,12 @@ static void put_char(struct tty_struct *tty, unsigned char ch) ...@@ -1071,10 +1072,12 @@ static void put_char(struct tty_struct *tty, unsigned char ch)
if (info->tx_put >= info->max_frame_size) if (info->tx_put >= info->max_frame_size)
info->tx_put -= info->max_frame_size; info->tx_put -= info->max_frame_size;
info->tx_count++; info->tx_count++;
ret = 1;
} }
} }
spin_unlock_irqrestore(&info->lock,flags); spin_unlock_irqrestore(&info->lock,flags);
return ret;
} }
/* Send a high-priority XON/XOFF character /* Send a high-priority XON/XOFF character
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment