Commit 4edf040a authored by Gábor Stefanik's avatar Gábor Stefanik Committed by John W. Linville

mac80211: Fix handling of retry count of NO_ACK frames in minstrel

Make the retry count zero (total try count = 1) for frames with
IEEE80211_TX_CTL_NO_ACK set.

Also remove the check for is_multicast_ether_addr in use_low_rate,
which is redundant because all multicasts have IEEE80211_TX_CTL_NO_ACK
set.
Signed-off-by: default avatarGábor Stefanik <netrolller.3d@gmail.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 2516baa6
...@@ -80,8 +80,7 @@ use_low_rate(struct sk_buff *skb) ...@@ -80,8 +80,7 @@ use_low_rate(struct sk_buff *skb)
fc = le16_to_cpu(hdr->frame_control); fc = le16_to_cpu(hdr->frame_control);
return ((info->flags & IEEE80211_TX_CTL_NO_ACK) || return ((info->flags & IEEE80211_TX_CTL_NO_ACK) ||
(fc & IEEE80211_FCTL_FTYPE) != IEEE80211_FTYPE_DATA || (fc & IEEE80211_FCTL_FTYPE) != IEEE80211_FTYPE_DATA);
is_multicast_ether_addr(hdr->addr1));
} }
...@@ -245,7 +244,10 @@ minstrel_get_rate(void *priv, struct ieee80211_sta *sta, ...@@ -245,7 +244,10 @@ minstrel_get_rate(void *priv, struct ieee80211_sta *sta,
if (!sta || !mi || use_low_rate(skb)) { if (!sta || !mi || use_low_rate(skb)) {
ar[0].idx = rate_lowest_index(sband, sta); ar[0].idx = rate_lowest_index(sband, sta);
ar[0].count = mp->max_retry; if (info->flags & IEEE80211_TX_CTL_NO_ACK)
ar[0].count = 1;
else
ar[0].count = mp->max_retry;
return; return;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment