Commit 4e231fa4 authored by Vladimir Serbinenko's avatar Vladimir Serbinenko Committed by Len Brown

ACPI video: ignore buggy _BQC

_BQC doesn't return a value listed in _BCL method.
http://bugzilla.kernel.org/show_bug.cgi?id=13511

ingore the buggy _BQC method in this case
Signed-off-by: default avatarVladimir Serbinenko <phcoder@gmail.com>
Signed-off-by: default avatarScott Howard <showard314@gmail.com>
Acked-by: default avatarZhang Rui <rui.zhang@intel.com>
Signed-off-by: default avatarLen Brown <len.brown@intel.com>
parent 3b5e6341
...@@ -603,6 +603,7 @@ acpi_video_device_lcd_get_level_current(struct acpi_video_device *device, ...@@ -603,6 +603,7 @@ acpi_video_device_lcd_get_level_current(struct acpi_video_device *device,
unsigned long long *level) unsigned long long *level)
{ {
acpi_status status = AE_OK; acpi_status status = AE_OK;
int i;
if (device->cap._BQC || device->cap._BCQ) { if (device->cap._BQC || device->cap._BCQ) {
char *buf = device->cap._BQC ? "_BQC" : "_BCQ"; char *buf = device->cap._BQC ? "_BQC" : "_BCQ";
...@@ -618,8 +619,15 @@ acpi_video_device_lcd_get_level_current(struct acpi_video_device *device, ...@@ -618,8 +619,15 @@ acpi_video_device_lcd_get_level_current(struct acpi_video_device *device,
} }
*level += bqc_offset_aml_bug_workaround; *level += bqc_offset_aml_bug_workaround;
device->brightness->curr = *level; for (i = 2; i < device->brightness->count; i++)
return 0; if (device->brightness->levels[i] == *level) {
device->brightness->curr = *level;
return 0;
}
/* BQC returned an invalid level. Stop using it. */
ACPI_WARNING((AE_INFO, "%s returned an invalid level",
buf));
device->cap._BQC = device->cap._BCQ = 0;
} else { } else {
/* Fixme: /* Fixme:
* should we return an error or ignore this failure? * should we return an error or ignore this failure?
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment