Commit 4bcfbab2 authored by Guennadi Liakhovetski's avatar Guennadi Liakhovetski Committed by Mauro Carvalho Chehab

V4L/DVB (12527): tw9910: do not lie about cropping abilities

The current tw9910 driver does not implement cropping correctly. Therefore, and
also because various rectangles in struct soc_camera_device are in user scale,
we cannot and shall not use rect_current as window location.
Signed-off-by: default avatarGuennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 42249f68
...@@ -719,9 +719,10 @@ static int tw9910_s_fmt(struct v4l2_subdev *sd, struct v4l2_format *f) ...@@ -719,9 +719,10 @@ static int tw9910_s_fmt(struct v4l2_subdev *sd, struct v4l2_format *f)
struct i2c_client *client = sd->priv; struct i2c_client *client = sd->priv;
struct soc_camera_device *icd = client->dev.platform_data; struct soc_camera_device *icd = client->dev.platform_data;
struct v4l2_pix_format *pix = &f->fmt.pix; struct v4l2_pix_format *pix = &f->fmt.pix;
/* See tw9910_set_crop() - no proper cropping support */
struct v4l2_rect rect = { struct v4l2_rect rect = {
.left = icd->rect_current.left, .left = 0,
.top = icd->rect_current.top, .top = 0,
.width = pix->width, .width = pix->width,
.height = pix->height, .height = pix->height,
}; };
...@@ -850,6 +851,7 @@ static struct v4l2_subdev_ops tw9910_subdev_ops = { ...@@ -850,6 +851,7 @@ static struct v4l2_subdev_ops tw9910_subdev_ops = {
* i2c_driver function * i2c_driver function
*/ */
/* This is called during probe, so, setting rect_max is Ok here: scale == 1 */
static void limit_to_scale(struct soc_camera_device *icd, static void limit_to_scale(struct soc_camera_device *icd,
const struct tw9910_scale_ctrl *scale) const struct tw9910_scale_ctrl *scale)
{ {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment