Commit 442ce844 authored by Dave Jones's avatar Dave Jones Committed by Sam Ravnborg

kbuild: reference_discarded addition

Error: ./fs/quota_v2.o .opd refers to 0000000000000020 R_PPC64_ADDR64    .exit.text

Been carrying this for some time in Red Hat trees.

Keith Ownes <kaos@sgi.com> commented:
For our future {in}sanity, add a comment that this is the ppc .opd
section, not the ia64 .opd section.  ia64 .opd should not point to
discarded sections.

Any idea why ppc .opd points to discarded sections when ia64 does not?
AFAICT no ia64 object has a useful .opd section, they are all empty or
(sometimes) a dummy entry which is 1 byte long.  ia64 .opd data is
built at link time, not compile time.
Signed-off-by: default avatarDave Jones <davej@redhat.com>
Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
parent 50aa88e2
...@@ -71,6 +71,11 @@ foreach $object (keys(%object)) { ...@@ -71,6 +71,11 @@ foreach $object (keys(%object)) {
# printf("ignoring %d conglomerate(s)\n", $ignore); # printf("ignoring %d conglomerate(s)\n", $ignore);
# printf("Scanning objects\n"); # printf("Scanning objects\n");
# Keith Ownes <kaos@sgi.com> commented:
# For our future {in}sanity, add a comment that this is the ppc .opd
# section, not the ia64 .opd section.
# ia64 .opd should not point to discarded sections.
$errorcount = 0; $errorcount = 0;
foreach $object (keys(%object)) { foreach $object (keys(%object)) {
my $from; my $from;
...@@ -88,6 +93,7 @@ foreach $object (keys(%object)) { ...@@ -88,6 +93,7 @@ foreach $object (keys(%object)) {
($from !~ /\.text\.exit$/ && ($from !~ /\.text\.exit$/ &&
$from !~ /\.exit\.text$/ && $from !~ /\.exit\.text$/ &&
$from !~ /\.data\.exit$/ && $from !~ /\.data\.exit$/ &&
$from !~ /\.opd$/ &&
$from !~ /\.exit\.data$/ && $from !~ /\.exit\.data$/ &&
$from !~ /\.altinstructions$/ && $from !~ /\.altinstructions$/ &&
$from !~ /\.pdr$/ && $from !~ /\.pdr$/ &&
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment