Commit 43af8532 authored by Volodymyr G Lukiianyk's avatar Volodymyr G Lukiianyk Committed by David S. Miller

bridge: fix error handling in br_add_if()

When device is added to bridge its refcnt is incremented (in new_nbp()), but if
error occurs during further br_add_if() operations this counter is not
decremented back. Fix it by adding dev_put() call in the error path.
Signed-off-by: default avatarVolodymyr G Lukiianyk <volodymyrgl@gmail.com>
Signed-off-by: default avatarStephen Hemminger <shemminger@vyatta.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9a732ed6
...@@ -411,9 +411,12 @@ err2: ...@@ -411,9 +411,12 @@ err2:
br_fdb_delete_by_port(br, p, 1); br_fdb_delete_by_port(br, p, 1);
err1: err1:
kobject_del(&p->kobj); kobject_del(&p->kobj);
return err; goto put_back;
err0: err0:
kobject_put(&p->kobj); kobject_put(&p->kobj);
put_back:
dev_put(dev);
return err; return err;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment