Commit 40b798ef authored by Thomas Gleixner's avatar Thomas Gleixner

drivers: Remove BKL from misc_open

misc_open() is already serialized with misc_mtx. Remove the BKL
locking which got there via the BKL pushdown.
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
LKML-Reference: <20091010153349.237173041@linutronix.de>
parent 80f50691
...@@ -49,7 +49,6 @@ ...@@ -49,7 +49,6 @@
#include <linux/device.h> #include <linux/device.h>
#include <linux/tty.h> #include <linux/tty.h>
#include <linux/kmod.h> #include <linux/kmod.h>
#include <linux/smp_lock.h>
/* /*
* Head entry for the doubly linked miscdevice list * Head entry for the doubly linked miscdevice list
...@@ -118,8 +117,7 @@ static int misc_open(struct inode * inode, struct file * file) ...@@ -118,8 +117,7 @@ static int misc_open(struct inode * inode, struct file * file)
struct miscdevice *c; struct miscdevice *c;
int err = -ENODEV; int err = -ENODEV;
const struct file_operations *old_fops, *new_fops = NULL; const struct file_operations *old_fops, *new_fops = NULL;
lock_kernel();
mutex_lock(&misc_mtx); mutex_lock(&misc_mtx);
list_for_each_entry(c, &misc_list, list) { list_for_each_entry(c, &misc_list, list) {
...@@ -157,7 +155,6 @@ static int misc_open(struct inode * inode, struct file * file) ...@@ -157,7 +155,6 @@ static int misc_open(struct inode * inode, struct file * file)
fops_put(old_fops); fops_put(old_fops);
fail: fail:
mutex_unlock(&misc_mtx); mutex_unlock(&misc_mtx);
unlock_kernel();
return err; return err;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment