Commit 3c3f4e01 authored by Akinobu Mita's avatar Akinobu Mita Committed by Jens Axboe

cdrom: cleanup hardcoded error-code

This patch eliminates hardcoded return value of register_cdrom().

It also changes the return value to -EINVAL.
It is more appropriate than -2 (-ENOENT) because it is only
happen invalid usage of register_cdrom() by broken cdrom driver.
Signed-off-by: default avatarAkinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: default avatarJens Axboe <jens.axboe@oracle.com>
parent 17672cf0
...@@ -393,7 +393,7 @@ int register_cdrom(struct cdrom_device_info *cdi) ...@@ -393,7 +393,7 @@ int register_cdrom(struct cdrom_device_info *cdi)
cdinfo(CD_OPEN, "entering register_cdrom\n"); cdinfo(CD_OPEN, "entering register_cdrom\n");
if (cdo->open == NULL || cdo->release == NULL) if (cdo->open == NULL || cdo->release == NULL)
return -2; return -EINVAL;
if (!banner_printed) { if (!banner_printed) {
printk(KERN_INFO "Uniform CD-ROM driver " REVISION "\n"); printk(KERN_INFO "Uniform CD-ROM driver " REVISION "\n");
banner_printed = 1; banner_printed = 1;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment