Commit 37f440cb authored by Peter Zijlstra's avatar Peter Zijlstra Committed by Ingo Molnar

pref_counter: tools: report: Add --sort option

option parsing for dynamic sorting.
Signed-off-by: default avatarPeter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: John Kacur <jkacur@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
LKML-Reference: <20090527182101.041817692@chello.nl>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent 1aa16738
...@@ -20,6 +20,7 @@ ...@@ -20,6 +20,7 @@
static char const *input_name = "perf.data"; static char const *input_name = "perf.data";
static char *vmlinux = NULL; static char *vmlinux = NULL;
static char *sort_order = "pid,symbol";
static int input; static int input;
static int show_mask = SHOW_KERNEL | SHOW_USER | SHOW_HV; static int show_mask = SHOW_KERNEL | SHOW_USER | SHOW_HV;
...@@ -770,12 +771,49 @@ static struct sort_entry sort_sym = { ...@@ -770,12 +771,49 @@ static struct sort_entry sort_sym = {
.print = sort__sym_print, .print = sort__sym_print,
}; };
struct sort_dimension {
char *name;
struct sort_entry *entry;
int taken;
};
static struct sort_dimension sort_dimensions[] = {
{ .name = "pid", .entry = &sort_thread, },
{ .name = "symbol", .entry = &sort_sym, },
};
static LIST_HEAD(hist_entry__sort_list); static LIST_HEAD(hist_entry__sort_list);
static int sort_dimension__add(char *tok)
{
int i;
for (i = 0; i < ARRAY_SIZE(sort_dimensions); i++) {
struct sort_dimension *sd = &sort_dimensions[i];
if (sd->taken)
continue;
if (strcmp(tok, sd->name))
continue;
list_add_tail(&sd->entry->list, &hist_entry__sort_list);
sd->taken = 1;
return 0;
}
return -ESRCH;
}
static void setup_sorting(void) static void setup_sorting(void)
{ {
list_add_tail(&sort_thread.list, &hist_entry__sort_list); char *tmp, *tok, *str = strdup(sort_order);
list_add_tail(&sort_sym.list, &hist_entry__sort_list);
for (tok = strtok_r(str, ", ", &tmp);
tok; tok = strtok_r(NULL, ", ", &tmp))
sort_dimension__add(tok);
free(str);
} }
static int64_t static int64_t
...@@ -1137,6 +1175,7 @@ static const struct option options[] = { ...@@ -1137,6 +1175,7 @@ static const struct option options[] = {
OPT_BOOLEAN('D', "dump-raw-trace", &dump_trace, OPT_BOOLEAN('D', "dump-raw-trace", &dump_trace,
"dump raw trace in ASCII"), "dump raw trace in ASCII"),
OPT_STRING('k', "vmlinux", &vmlinux, "file", "vmlinux pathname"), OPT_STRING('k', "vmlinux", &vmlinux, "file", "vmlinux pathname"),
OPT_STRING('s', "sort", &sort_order, "foo", "bar"),
OPT_END() OPT_END()
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment