Commit 3760dd6e authored by Andi Kleen's avatar Andi Kleen Committed by Andi Kleen

[PATCH] i386: Use CLFLUSH instead of WBINVD in change_page_attr

CLFLUSH is a lot faster than WBINVD so try to use that.
Signed-off-by: default avatarAndi Kleen <ak@suse.de>
parent 770d132f
...@@ -67,11 +67,17 @@ static struct page *split_large_page(unsigned long address, pgprot_t prot, ...@@ -67,11 +67,17 @@ static struct page *split_large_page(unsigned long address, pgprot_t prot,
return base; return base;
} }
static void flush_kernel_map(void *dummy) static void flush_kernel_map(void *arg)
{ {
/* Could use CLFLUSH here if the CPU supports it (Hammer,P4) */ unsigned long adr = (unsigned long)arg;
if (boot_cpu_data.x86_model >= 4)
if (adr && cpu_has_clflush) {
int i;
for (i = 0; i < PAGE_SIZE; i += boot_cpu_data.x86_clflush_size)
asm volatile("clflush (%0)" :: "r" (adr + i));
} else if (boot_cpu_data.x86_model >= 4)
wbinvd(); wbinvd();
/* Flush all to work around Errata in early athlons regarding /* Flush all to work around Errata in early athlons regarding
* large page flushing. * large page flushing.
*/ */
...@@ -173,9 +179,9 @@ __change_page_attr(struct page *page, pgprot_t prot) ...@@ -173,9 +179,9 @@ __change_page_attr(struct page *page, pgprot_t prot)
return 0; return 0;
} }
static inline void flush_map(void) static inline void flush_map(void *adr)
{ {
on_each_cpu(flush_kernel_map, NULL, 1, 1); on_each_cpu(flush_kernel_map, adr, 1, 1);
} }
/* /*
...@@ -217,9 +223,13 @@ void global_flush_tlb(void) ...@@ -217,9 +223,13 @@ void global_flush_tlb(void)
spin_lock_irq(&cpa_lock); spin_lock_irq(&cpa_lock);
list_replace_init(&df_list, &l); list_replace_init(&df_list, &l);
spin_unlock_irq(&cpa_lock); spin_unlock_irq(&cpa_lock);
flush_map(); if (!cpu_has_clflush)
list_for_each_entry_safe(pg, next, &l, lru) flush_map(0);
list_for_each_entry_safe(pg, next, &l, lru) {
if (cpu_has_clflush)
flush_map(page_address(pg));
__free_page(pg); __free_page(pg);
}
} }
#ifdef CONFIG_DEBUG_PAGEALLOC #ifdef CONFIG_DEBUG_PAGEALLOC
......
...@@ -137,6 +137,7 @@ ...@@ -137,6 +137,7 @@
#define cpu_has_pmm_enabled boot_cpu_has(X86_FEATURE_PMM_EN) #define cpu_has_pmm_enabled boot_cpu_has(X86_FEATURE_PMM_EN)
#define cpu_has_ds boot_cpu_has(X86_FEATURE_DS) #define cpu_has_ds boot_cpu_has(X86_FEATURE_DS)
#define cpu_has_pebs boot_cpu_has(X86_FEATURE_PEBS) #define cpu_has_pebs boot_cpu_has(X86_FEATURE_PEBS)
#define cpu_has_clflush boot_cpu_has(X86_FEATURE_CLFLSH)
#endif /* __ASM_I386_CPUFEATURE_H */ #endif /* __ASM_I386_CPUFEATURE_H */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment