Commit 2950e952 authored by Jos-Vicente Gilabert's avatar Jos-Vicente Gilabert Committed by David S. Miller

drivers/net/irda/irda-usb.c: fix buffer overflow

Taken from http://bugzilla.kernel.org/show_bug.cgi?id=12397

We're doing an sprintf of an 11-char string into an 11-char buffer. 
Whoops.  It breaks firmware uploading.
Reported-by: default avatarJos-Vicente Gilabert <josevteg@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6f703406
...@@ -1073,7 +1073,7 @@ static int stir421x_patch_device(struct irda_usb_cb *self) ...@@ -1073,7 +1073,7 @@ static int stir421x_patch_device(struct irda_usb_cb *self)
{ {
unsigned int i; unsigned int i;
int ret; int ret;
char stir421x_fw_name[11]; char stir421x_fw_name[12];
const struct firmware *fw; const struct firmware *fw;
const unsigned char *fw_version_ptr; /* pointer to version string */ const unsigned char *fw_version_ptr; /* pointer to version string */
unsigned long fw_version = 0; unsigned long fw_version = 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment