Commit 29321357 authored by Vladimir Zajac's avatar Vladimir Zajac Committed by Len Brown

thermal: fix off-by-1 error in trip point trigger condition

This patch fixes a regression caused by commit
b1569e99
"ACPI: move thermal trip handling to generic thermal layer"
which accidentally changed trip point trigger condition to
  temp > trip_temp

This patch changes the trigger condition back to
  temp >= trip_temp
Signed-off-by: default avatarVladimir Zajac <eightgraph@gmail.com>
Acked-by: default avatarZhang Rui <rui.zhang@intel.com>
Acked-by: default avatarMatthew Garrett <mjg@redhat.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLen Brown <len.brown@intel.com>
parent 091bf762
...@@ -961,7 +961,7 @@ void thermal_zone_device_update(struct thermal_zone_device *tz) ...@@ -961,7 +961,7 @@ void thermal_zone_device_update(struct thermal_zone_device *tz)
switch (trip_type) { switch (trip_type) {
case THERMAL_TRIP_CRITICAL: case THERMAL_TRIP_CRITICAL:
if (temp > trip_temp) { if (temp >= trip_temp) {
if (tz->ops->notify) if (tz->ops->notify)
ret = tz->ops->notify(tz, count, ret = tz->ops->notify(tz, count,
trip_type); trip_type);
...@@ -974,7 +974,7 @@ void thermal_zone_device_update(struct thermal_zone_device *tz) ...@@ -974,7 +974,7 @@ void thermal_zone_device_update(struct thermal_zone_device *tz)
} }
break; break;
case THERMAL_TRIP_HOT: case THERMAL_TRIP_HOT:
if (temp > trip_temp) if (temp >= trip_temp)
if (tz->ops->notify) if (tz->ops->notify)
tz->ops->notify(tz, count, trip_type); tz->ops->notify(tz, count, trip_type);
break; break;
...@@ -986,14 +986,14 @@ void thermal_zone_device_update(struct thermal_zone_device *tz) ...@@ -986,14 +986,14 @@ void thermal_zone_device_update(struct thermal_zone_device *tz)
cdev = instance->cdev; cdev = instance->cdev;
if (temp > trip_temp) if (temp >= trip_temp)
cdev->ops->set_cur_state(cdev, 1); cdev->ops->set_cur_state(cdev, 1);
else else
cdev->ops->set_cur_state(cdev, 0); cdev->ops->set_cur_state(cdev, 0);
} }
break; break;
case THERMAL_TRIP_PASSIVE: case THERMAL_TRIP_PASSIVE:
if (temp > trip_temp || tz->passive) if (temp >= trip_temp || tz->passive)
thermal_zone_device_passive(tz, temp, thermal_zone_device_passive(tz, temp,
trip_temp, count); trip_temp, count);
break; break;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment