Commit 266e0e21 authored by Pierre Habouzit's avatar Pierre Habouzit Committed by Ingo Molnar

perf record: Fix the -A UI for empty or non-existent perf.data

1. Ignore the -A argument if there is no perf.data file
2. Treat an empty file like a non existent file.

Else, perf will try to read the perf.data header, and fail with
an error.

Treating an empty file like a non-existent file makes sense,
since an interupted (as in SIGKILLed) perf could leave such
files around, and you don't want to annoy the user with errors
for files with no data in it.
Signed-off-by: default avatarPierre Habouzit <pierre.habouzit@intersec.com>
Acked-by: default avatarPeter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent 7eac7e9e
...@@ -525,10 +525,14 @@ static int __cmd_record(int argc, const char **argv) ...@@ -525,10 +525,14 @@ static int __cmd_record(int argc, const char **argv)
signal(SIGCHLD, sig_handler); signal(SIGCHLD, sig_handler);
signal(SIGINT, sig_handler); signal(SIGINT, sig_handler);
if (!stat(output_name, &st) && !force && !append_file) { if (!stat(output_name, &st) && st.st_size) {
fprintf(stderr, "Error, output file %s exists, use -A to append or -f to overwrite.\n", if (!force && !append_file) {
output_name); fprintf(stderr, "Error, output file %s exists, use -A to append or -f to overwrite.\n",
exit(-1); output_name);
exit(-1);
}
} else {
append_file = 0;
} }
flags = O_CREAT|O_RDWR; flags = O_CREAT|O_RDWR;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment