Skip to content

L
linux-davinci
Commit 258fa999 authored by Al Viro's avatar Al Viro
Browse files
Options

lift path_put(path) to callers of __do_follow_link() 

Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent d231412d
Hide whitespace changes
Inline Side-by-side
Showing with 2 additions and 2 deletions
fs/namei.c
View file @ 258fa999
...@@ -644,8 +644,6 @@ static __always_inline int __do_follow_link(struct path *path, struct nameidata ...@@ -644,8 +644,6 @@ static __always_inline int __do_follow_link(struct path *path, struct nameidata
if (dentry->d_inode->i_op->put_link) if (dentry->d_inode->i_op->put_link)
dentry->d_inode->i_op->put_link(dentry, nd, cookie); dentry->d_inode->i_op->put_link(dentry, nd, cookie);
} }
path_put(path);
return error; return error;
} }
...@@ -672,6 +670,7 @@ static inline int do_follow_link(struct path *path, struct nameidata *nd) ...@@ -672,6 +670,7 @@ static inline int do_follow_link(struct path *path, struct nameidata *nd)
current->total_link_count++; current->total_link_count++;
nd->depth++; nd->depth++;
err = __do_follow_link(path, nd); err = __do_follow_link(path, nd);
path_put(path);
current->link_count--; current->link_count--;
nd->depth--; nd->depth--;
return err; return err;
...@@ -1864,6 +1863,7 @@ do_link: ...@@ -1864,6 +1863,7 @@ do_link:
if (error) if (error)
goto exit_dput; goto exit_dput;
error = __do_follow_link(&path, &nd); error = __do_follow_link(&path, &nd);
path_put(&path);
if (error) { if (error) {
/* Does someone understand code flow here? Or it is only /* Does someone understand code flow here? Or it is only
* me so stupid? Anathema to whoever designed this non-sense * me so stupid? Anathema to whoever designed this non-sense
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment