Commit 257ba15c authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Jan Kara

dquot: move dquot drop responsibility into the filesystem

Currently clear_inode calls vfs_dq_drop directly.  This means
we tie the quota code into the VFS.  Get rid of that and make the
filesystem responsible for the drop inside the ->clear_inode
superblock operation.
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarJan Kara <jack@suse.cz>
parent b43fa828
...@@ -194,6 +194,8 @@ static void destroy_inodecache(void) ...@@ -194,6 +194,8 @@ static void destroy_inodecache(void)
static void ext2_clear_inode(struct inode *inode) static void ext2_clear_inode(struct inode *inode)
{ {
struct ext2_block_alloc_info *rsv = EXT2_I(inode)->i_block_alloc_info; struct ext2_block_alloc_info *rsv = EXT2_I(inode)->i_block_alloc_info;
vfs_dq_drop(inode);
ext2_discard_reservation(inode); ext2_discard_reservation(inode);
EXT2_I(inode)->i_block_alloc_info = NULL; EXT2_I(inode)->i_block_alloc_info = NULL;
if (unlikely(rsv)) if (unlikely(rsv))
......
...@@ -528,6 +528,8 @@ static void destroy_inodecache(void) ...@@ -528,6 +528,8 @@ static void destroy_inodecache(void)
static void ext3_clear_inode(struct inode *inode) static void ext3_clear_inode(struct inode *inode)
{ {
struct ext3_block_alloc_info *rsv = EXT3_I(inode)->i_block_alloc_info; struct ext3_block_alloc_info *rsv = EXT3_I(inode)->i_block_alloc_info;
vfs_dq_drop(inode);
ext3_discard_reservation(inode); ext3_discard_reservation(inode);
EXT3_I(inode)->i_block_alloc_info = NULL; EXT3_I(inode)->i_block_alloc_info = NULL;
if (unlikely(rsv)) if (unlikely(rsv))
......
...@@ -761,6 +761,7 @@ static void destroy_inodecache(void) ...@@ -761,6 +761,7 @@ static void destroy_inodecache(void)
static void ext4_clear_inode(struct inode *inode) static void ext4_clear_inode(struct inode *inode)
{ {
vfs_dq_drop(inode);
ext4_discard_preallocations(inode); ext4_discard_preallocations(inode);
if (EXT4_JOURNAL(inode)) if (EXT4_JOURNAL(inode))
jbd2_journal_release_jbd_inode(EXT4_SB(inode->i_sb)->s_journal, jbd2_journal_release_jbd_inode(EXT4_SB(inode->i_sb)->s_journal,
......
...@@ -314,7 +314,6 @@ void clear_inode(struct inode *inode) ...@@ -314,7 +314,6 @@ void clear_inode(struct inode *inode)
BUG_ON(!(inode->i_state & I_FREEING)); BUG_ON(!(inode->i_state & I_FREEING));
BUG_ON(inode->i_state & I_CLEAR); BUG_ON(inode->i_state & I_CLEAR);
inode_sync_wait(inode); inode_sync_wait(inode);
vfs_dq_drop(inode);
if (inode->i_sb->s_op->clear_inode) if (inode->i_sb->s_op->clear_inode)
inode->i_sb->s_op->clear_inode(inode); inode->i_sb->s_op->clear_inode(inode);
if (S_ISBLK(inode->i_mode) && inode->i_bdev) if (S_ISBLK(inode->i_mode) && inode->i_bdev)
......
...@@ -131,6 +131,11 @@ static void jfs_destroy_inode(struct inode *inode) ...@@ -131,6 +131,11 @@ static void jfs_destroy_inode(struct inode *inode)
kmem_cache_free(jfs_inode_cachep, ji); kmem_cache_free(jfs_inode_cachep, ji);
} }
static void jfs_clear_inode(struct inode *inode)
{
vfs_dq_drop(inode);
}
static int jfs_statfs(struct dentry *dentry, struct kstatfs *buf) static int jfs_statfs(struct dentry *dentry, struct kstatfs *buf)
{ {
struct jfs_sb_info *sbi = JFS_SBI(dentry->d_sb); struct jfs_sb_info *sbi = JFS_SBI(dentry->d_sb);
...@@ -745,6 +750,7 @@ static const struct super_operations jfs_super_operations = { ...@@ -745,6 +750,7 @@ static const struct super_operations jfs_super_operations = {
.dirty_inode = jfs_dirty_inode, .dirty_inode = jfs_dirty_inode,
.write_inode = jfs_write_inode, .write_inode = jfs_write_inode,
.delete_inode = jfs_delete_inode, .delete_inode = jfs_delete_inode,
.clear_inode = jfs_clear_inode,
.put_super = jfs_put_super, .put_super = jfs_put_super,
.sync_fs = jfs_sync_fs, .sync_fs = jfs_sync_fs,
.freeze_fs = jfs_freeze, .freeze_fs = jfs_freeze,
......
...@@ -1087,6 +1087,8 @@ void ocfs2_clear_inode(struct inode *inode) ...@@ -1087,6 +1087,8 @@ void ocfs2_clear_inode(struct inode *inode)
mlog_bug_on_msg(OCFS2_SB(inode->i_sb) == NULL, mlog_bug_on_msg(OCFS2_SB(inode->i_sb) == NULL,
"Inode=%lu\n", inode->i_ino); "Inode=%lu\n", inode->i_ino);
vfs_dq_drop(inode);
/* To preven remote deletes we hold open lock before, now it /* To preven remote deletes we hold open lock before, now it
* is time to unlock PR and EX open locks. */ * is time to unlock PR and EX open locks. */
ocfs2_open_unlock(inode); ocfs2_open_unlock(inode);
......
...@@ -578,6 +578,11 @@ out: ...@@ -578,6 +578,11 @@ out:
reiserfs_write_unlock_once(inode->i_sb, lock_depth); reiserfs_write_unlock_once(inode->i_sb, lock_depth);
} }
static void reiserfs_clear_inode(struct inode *inode)
{
vfs_dq_drop(inode);
}
#ifdef CONFIG_QUOTA #ifdef CONFIG_QUOTA
static ssize_t reiserfs_quota_write(struct super_block *, int, const char *, static ssize_t reiserfs_quota_write(struct super_block *, int, const char *,
size_t, loff_t); size_t, loff_t);
...@@ -590,6 +595,7 @@ static const struct super_operations reiserfs_sops = { ...@@ -590,6 +595,7 @@ static const struct super_operations reiserfs_sops = {
.destroy_inode = reiserfs_destroy_inode, .destroy_inode = reiserfs_destroy_inode,
.write_inode = reiserfs_write_inode, .write_inode = reiserfs_write_inode,
.dirty_inode = reiserfs_dirty_inode, .dirty_inode = reiserfs_dirty_inode,
.clear_inode = reiserfs_clear_inode,
.delete_inode = reiserfs_delete_inode, .delete_inode = reiserfs_delete_inode,
.put_super = reiserfs_put_super, .put_super = reiserfs_put_super,
.write_super = reiserfs_write_super, .write_super = reiserfs_write_super,
......
...@@ -108,6 +108,8 @@ void udf_clear_inode(struct inode *inode) ...@@ -108,6 +108,8 @@ void udf_clear_inode(struct inode *inode)
(unsigned long long)inode->i_size, (unsigned long long)inode->i_size,
(unsigned long long)iinfo->i_lenExtents); (unsigned long long)iinfo->i_lenExtents);
} }
vfs_dq_drop(inode);
kfree(iinfo->i_ext.i_data); kfree(iinfo->i_ext.i_data);
iinfo->i_ext.i_data = NULL; iinfo->i_ext.i_data = NULL;
} }
......
...@@ -1432,6 +1432,11 @@ static void destroy_inodecache(void) ...@@ -1432,6 +1432,11 @@ static void destroy_inodecache(void)
kmem_cache_destroy(ufs_inode_cachep); kmem_cache_destroy(ufs_inode_cachep);
} }
static void ufs_clear_inode(struct inode *inode)
{
vfs_dq_drop(inode);
}
#ifdef CONFIG_QUOTA #ifdef CONFIG_QUOTA
static ssize_t ufs_quota_read(struct super_block *, int, char *,size_t, loff_t); static ssize_t ufs_quota_read(struct super_block *, int, char *,size_t, loff_t);
static ssize_t ufs_quota_write(struct super_block *, int, const char *, size_t, loff_t); static ssize_t ufs_quota_write(struct super_block *, int, const char *, size_t, loff_t);
...@@ -1442,6 +1447,7 @@ static const struct super_operations ufs_super_ops = { ...@@ -1442,6 +1447,7 @@ static const struct super_operations ufs_super_ops = {
.destroy_inode = ufs_destroy_inode, .destroy_inode = ufs_destroy_inode,
.write_inode = ufs_write_inode, .write_inode = ufs_write_inode,
.delete_inode = ufs_delete_inode, .delete_inode = ufs_delete_inode,
.clear_inode = ufs_clear_inode,
.put_super = ufs_put_super, .put_super = ufs_put_super,
.write_super = ufs_write_super, .write_super = ufs_write_super,
.sync_fs = ufs_sync_fs, .sync_fs = ufs_sync_fs,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment