Commit 23475e26 authored by Roel Kluin's avatar Roel Kluin Committed by Theodore Ts'o

ext4: Use simple_strtol() instead of simple_strtoul() in ext4_ui_proc_open

Signed-off-by: default avatarRoel Kluin <roel.kluin@gmail.com>
Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
parent 171bbfbe
...@@ -3521,18 +3521,15 @@ static int ext4_ui_proc_open(struct inode *inode, struct file *file) ...@@ -3521,18 +3521,15 @@ static int ext4_ui_proc_open(struct inode *inode, struct file *file)
static ssize_t ext4_ui_proc_write(struct file *file, const char __user *buf, static ssize_t ext4_ui_proc_write(struct file *file, const char __user *buf,
size_t cnt, loff_t *ppos) size_t cnt, loff_t *ppos)
{ {
unsigned int *p = PDE(file->f_path.dentry->d_inode)->data; unsigned long *p = PDE(file->f_path.dentry->d_inode)->data;
char str[32]; char str[32];
unsigned long value;
if (cnt >= sizeof(str)) if (cnt >= sizeof(str))
return -EINVAL; return -EINVAL;
if (copy_from_user(str, buf, cnt)) if (copy_from_user(str, buf, cnt))
return -EFAULT; return -EFAULT;
value = simple_strtol(str, NULL, 0);
if (value < 0) *p = simple_strtoul(str, NULL, 0);
return -ERANGE;
*p = value;
return cnt; return cnt;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment