Commit 1dff3996 authored by Rusty Russell's avatar Rusty Russell

hvc_console: make the ops pointer const.

This is nicer for modern R/O protection.  And noone needs it non-const, so
constify the callers as well.
Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
Signed-off-by: default avatarAmit Shah <amit.shah@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: linuxppc-dev@ozlabs.org
parent 971f3390
...@@ -84,7 +84,7 @@ static int hvc_beat_put_chars(uint32_t vtermno, const char *buf, int cnt) ...@@ -84,7 +84,7 @@ static int hvc_beat_put_chars(uint32_t vtermno, const char *buf, int cnt)
return cnt; return cnt;
} }
static struct hv_ops hvc_beat_get_put_ops = { static const struct hv_ops hvc_beat_get_put_ops = {
.get_chars = hvc_beat_get_chars, .get_chars = hvc_beat_get_chars,
.put_chars = hvc_beat_put_chars, .put_chars = hvc_beat_put_chars,
}; };
......
...@@ -125,7 +125,7 @@ static struct hvc_struct *hvc_get_by_index(int index) ...@@ -125,7 +125,7 @@ static struct hvc_struct *hvc_get_by_index(int index)
* console interfaces but can still be used as a tty device. This has to be * console interfaces but can still be used as a tty device. This has to be
* static because kmalloc will not work during early console init. * static because kmalloc will not work during early console init.
*/ */
static struct hv_ops *cons_ops[MAX_NR_HVC_CONSOLES]; static const struct hv_ops *cons_ops[MAX_NR_HVC_CONSOLES];
static uint32_t vtermnos[MAX_NR_HVC_CONSOLES] = static uint32_t vtermnos[MAX_NR_HVC_CONSOLES] =
{[0 ... MAX_NR_HVC_CONSOLES - 1] = -1}; {[0 ... MAX_NR_HVC_CONSOLES - 1] = -1};
...@@ -247,7 +247,7 @@ static void destroy_hvc_struct(struct kref *kref) ...@@ -247,7 +247,7 @@ static void destroy_hvc_struct(struct kref *kref)
* vty adapters do NOT get an hvc_instantiate() callback since they * vty adapters do NOT get an hvc_instantiate() callback since they
* appear after early console init. * appear after early console init.
*/ */
int hvc_instantiate(uint32_t vtermno, int index, struct hv_ops *ops) int hvc_instantiate(uint32_t vtermno, int index, const struct hv_ops *ops)
{ {
struct hvc_struct *hp; struct hvc_struct *hp;
...@@ -749,7 +749,8 @@ static const struct tty_operations hvc_ops = { ...@@ -749,7 +749,8 @@ static const struct tty_operations hvc_ops = {
}; };
struct hvc_struct __devinit *hvc_alloc(uint32_t vtermno, int data, struct hvc_struct __devinit *hvc_alloc(uint32_t vtermno, int data,
struct hv_ops *ops, int outbuf_size) const struct hv_ops *ops,
int outbuf_size)
{ {
struct hvc_struct *hp; struct hvc_struct *hp;
int i; int i;
......
...@@ -55,7 +55,7 @@ struct hvc_struct { ...@@ -55,7 +55,7 @@ struct hvc_struct {
int outbuf_size; int outbuf_size;
int n_outbuf; int n_outbuf;
uint32_t vtermno; uint32_t vtermno;
struct hv_ops *ops; const struct hv_ops *ops;
int irq_requested; int irq_requested;
int data; int data;
struct winsize ws; struct winsize ws;
...@@ -76,11 +76,12 @@ struct hv_ops { ...@@ -76,11 +76,12 @@ struct hv_ops {
}; };
/* Register a vterm and a slot index for use as a console (console_init) */ /* Register a vterm and a slot index for use as a console (console_init) */
extern int hvc_instantiate(uint32_t vtermno, int index, struct hv_ops *ops); extern int hvc_instantiate(uint32_t vtermno, int index,
const struct hv_ops *ops);
/* register a vterm for hvc tty operation (module_init or hotplug add) */ /* register a vterm for hvc tty operation (module_init or hotplug add) */
extern struct hvc_struct * __devinit hvc_alloc(uint32_t vtermno, int data, extern struct hvc_struct * __devinit hvc_alloc(uint32_t vtermno, int data,
struct hv_ops *ops, int outbuf_size); const struct hv_ops *ops, int outbuf_size);
/* remove a vterm from hvc tty operation (module_exit or hotplug remove) */ /* remove a vterm from hvc tty operation (module_exit or hotplug remove) */
extern int hvc_remove(struct hvc_struct *hp); extern int hvc_remove(struct hvc_struct *hp);
......
...@@ -197,7 +197,7 @@ done: ...@@ -197,7 +197,7 @@ done:
return sent; return sent;
} }
static struct hv_ops hvc_get_put_ops = { static const struct hv_ops hvc_get_put_ops = {
.get_chars = get_chars, .get_chars = get_chars,
.put_chars = put_chars, .put_chars = put_chars,
.notifier_add = notifier_add_irq, .notifier_add = notifier_add_irq,
......
...@@ -922,7 +922,7 @@ static int hvc_iucv_pm_restore_thaw(struct device *dev) ...@@ -922,7 +922,7 @@ static int hvc_iucv_pm_restore_thaw(struct device *dev)
/* HVC operations */ /* HVC operations */
static struct hv_ops hvc_iucv_ops = { static const struct hv_ops hvc_iucv_ops = {
.get_chars = hvc_iucv_get_chars, .get_chars = hvc_iucv_get_chars,
.put_chars = hvc_iucv_put_chars, .put_chars = hvc_iucv_put_chars,
.notifier_add = hvc_iucv_notifier_add, .notifier_add = hvc_iucv_notifier_add,
......
...@@ -71,7 +71,7 @@ static int hvc_rtas_read_console(uint32_t vtermno, char *buf, int count) ...@@ -71,7 +71,7 @@ static int hvc_rtas_read_console(uint32_t vtermno, char *buf, int count)
return i; return i;
} }
static struct hv_ops hvc_rtas_get_put_ops = { static const struct hv_ops hvc_rtas_get_put_ops = {
.get_chars = hvc_rtas_read_console, .get_chars = hvc_rtas_read_console,
.put_chars = hvc_rtas_write_console, .put_chars = hvc_rtas_write_console,
}; };
......
...@@ -58,7 +58,7 @@ static int hvc_udbg_get(uint32_t vtermno, char *buf, int count) ...@@ -58,7 +58,7 @@ static int hvc_udbg_get(uint32_t vtermno, char *buf, int count)
return i; return i;
} }
static struct hv_ops hvc_udbg_ops = { static const struct hv_ops hvc_udbg_ops = {
.get_chars = hvc_udbg_get, .get_chars = hvc_udbg_get,
.put_chars = hvc_udbg_put, .put_chars = hvc_udbg_put,
}; };
......
...@@ -77,7 +77,7 @@ static int filtered_get_chars(uint32_t vtermno, char *buf, int count) ...@@ -77,7 +77,7 @@ static int filtered_get_chars(uint32_t vtermno, char *buf, int count)
return got; return got;
} }
static struct hv_ops hvc_get_put_ops = { static const struct hv_ops hvc_get_put_ops = {
.get_chars = filtered_get_chars, .get_chars = filtered_get_chars,
.put_chars = hvc_put_chars, .put_chars = hvc_put_chars,
.notifier_add = notifier_add_irq, .notifier_add = notifier_add_irq,
......
...@@ -122,7 +122,7 @@ static int read_console(uint32_t vtermno, char *buf, int len) ...@@ -122,7 +122,7 @@ static int read_console(uint32_t vtermno, char *buf, int len)
return recv; return recv;
} }
static struct hv_ops hvc_ops = { static const struct hv_ops hvc_ops = {
.get_chars = read_console, .get_chars = read_console,
.put_chars = write_console, .put_chars = write_console,
.notifier_add = notifier_add_irq, .notifier_add = notifier_add_irq,
......
...@@ -163,7 +163,7 @@ static void hvc_handle_input(struct virtqueue *vq) ...@@ -163,7 +163,7 @@ static void hvc_handle_input(struct virtqueue *vq)
} }
/* The operations for the console. */ /* The operations for the console. */
static struct hv_ops hv_ops = { static const struct hv_ops hv_ops = {
.get_chars = get_chars, .get_chars = get_chars,
.put_chars = put_chars, .put_chars = put_chars,
.notifier_add = notifier_add_vio, .notifier_add = notifier_add_vio,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment