Commit 19dc74b7 authored by Trent Piepho's avatar Trent Piepho Committed by Mauro Carvalho Chehab

V4L/DVB (5975): cx88: Wrong values used for HD-3000 radio mode

After some tedious work with a logic probe and a magnifying glass, I've
determined that GPIO 7 is used to switch between the DTT7612's Sound 4.5 MHz
IF output on pin 12 and the FM 10.7MHz If output on pin 11.  GPIO 2 is used to
switch the card's analog sound output from from the analog input connector to
the CX23883's audio DACs.

So, in radio mode GPIO2 = 1 and GPIO7 = 0.

Add some comments about how the HD-3000's GPIOs are connected.

Delete the vmux setting for the radio, as vmux doesn't apply to radio mode.
Also delete the lines setting unused gpio words to zero; it's not necessary as
0 is the default value for uninitialized fields.
Signed-off-by: default avatarTrent Piepho <xyzzy@speakeasy.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@infradead.org>
parent bfd7beac
......@@ -575,35 +575,34 @@ struct cx88_board cx88_boards[] = {
.tuner_addr = ADDR_UNSET,
.radio_addr = ADDR_UNSET,
.tda9887_conf = TDA9887_PRESENT,
/* GPIO[2] = audio source for analog audio out connector
* 0 = analog audio input connector
* 1 = CX88 audio DACs
*
* GPIO[7] = input to CX88's audio/chroma ADC
* 0 = FM 10.7 MHz IF
* 1 = Sound 4.5 MHz IF
*
* GPIO[1,5,6] = Oren 51132 pins 27,35,28 respectively
*
* GPIO[16] = Remote control input
*/
.input = {{
.type = CX88_VMUX_TELEVISION,
.vmux = 0,
.gpio0 = 0x00008484,
.gpio1 = 0x00000000,
.gpio2 = 0x00000000,
.gpio3 = 0x00000000,
},{
.type = CX88_VMUX_COMPOSITE1,
.vmux = 1,
.gpio0 = 0x00008400,
.gpio1 = 0x00000000,
.gpio2 = 0x00000000,
.gpio3 = 0x00000000,
},{
.type = CX88_VMUX_SVIDEO,
.vmux = 2,
.gpio0 = 0x00008400,
.gpio1 = 0x00000000,
.gpio2 = 0x00000000,
.gpio3 = 0x00000000,
}},
.radio = {
.type = CX88_RADIO,
.vmux = 2,
.gpio0 = 0x00008400,
.gpio1 = 0x00000000,
.gpio2 = 0x00000000,
.gpio3 = 0x00000000,
.gpio0 = 0x00008404,
},
.mpeg = CX88_MPEG_DVB,
},
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment