Commit 152a649b authored by Casey Schaufler's avatar Casey Schaufler Committed by Linus Torvalds

smackfs load append mode fix

Given just how hard it is to find the code that uses MAY_APPEND
it's probably not a big surprise that this went unnoticed for so
long. The Smack rules loading code is incorrectly setting the
MAY_READ bit when MAY_APPEND is requested.
Signed-off-by: default avatarCasey Schaufler <casey@schaufler-ca.com>
Reviewed-by: default avatarJames Morris <jmorris@namei.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent e4a7ca29
...@@ -334,7 +334,7 @@ static ssize_t smk_write_load(struct file *file, const char __user *buf, ...@@ -334,7 +334,7 @@ static ssize_t smk_write_load(struct file *file, const char __user *buf,
break; break;
case 'a': case 'a':
case 'A': case 'A':
rule.smk_access |= MAY_READ; rule.smk_access |= MAY_APPEND;
break; break;
default: default:
goto out; goto out;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment