Commit 03b88a66 authored by Jaswinder Singh Rajput's avatar Jaswinder Singh Rajput Committed by David S. Miller

pcmcia: pcnet_cs.c removing useless condition

'if (i < NR_INFO)' will only true if we breaks from 'for (i = 0; i < NR_INFO; i++)'
So removing useless 'if (i < NR_INFO)'

This also fixed following compilation warning :

  CC [M]  drivers/net/pcmcia/pcnet_cs.o
drivers/net/pcmcia/pcnet_cs.c: In function ‘get_hwinfo’:
drivers/net/pcmcia/pcnet_cs.c:321: warning: ‘base’ may be used uninitialized in this function
Signed-off-by: default avatarJaswinder Singh Rajput <jaswinderrajput@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 44c852ea
...@@ -340,12 +340,11 @@ static hw_info_t *get_hwinfo(struct pcmcia_device *link) ...@@ -340,12 +340,11 @@ static hw_info_t *get_hwinfo(struct pcmcia_device *link)
base = &virt[hw_info[i].offset & (req.Size-1)]; base = &virt[hw_info[i].offset & (req.Size-1)];
if ((readb(base+0) == hw_info[i].a0) && if ((readb(base+0) == hw_info[i].a0) &&
(readb(base+2) == hw_info[i].a1) && (readb(base+2) == hw_info[i].a1) &&
(readb(base+4) == hw_info[i].a2)) (readb(base+4) == hw_info[i].a2)) {
break; for (j = 0; j < 6; j++)
} dev->dev_addr[j] = readb(base + (j<<1));
if (i < NR_INFO) { break;
for (j = 0; j < 6; j++) }
dev->dev_addr[j] = readb(base + (j<<1));
} }
iounmap(virt); iounmap(virt);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment